Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Conversation
This was referenced Mar 16, 2017
hybrist
commented
Mar 16, 2017
| } | ||
| function runScript(script, scriptArgs, inspectHost, inspectPort, childPrint) { | ||
| return portIsFree(inspectHost, inspectPort) |
CollaboratorAuthor
There was a problem hiding this comment.
Moving the port check here so it's skipped for remote debugging. Waiting or the the port to be available doesn't make sense for node inspect <host>:<port>/node inspect -p <pid>.
hybrist
commented
Mar 16, 2017
| port = parseInt(portMatch[1], 10); | ||
| script = args[0]; | ||
| scriptArgs = args.slice(1); | ||
| } else if (args.length === 1 && /^\d+$/.test(args[0]) && target === '-p') { |
CollaboratorAuthor
There was a problem hiding this comment.
Pretty much 1:1 copy of the existing _debugger.js code.
hybrist
commented
Mar 16, 2017
CollaboratorAuthor
/cc @nodejs/diagnostics |
hybrist
commented
Apr 3, 2017
CollaboratorAuthor
Manually tested rebased version against nodejs/node#11431, still works. |
hybrist
commented
Apr 4, 2017
CollaboratorAuthor
@joshgav If you have some time, this is the last bit that still needs a review. |
bnoordhuis
approved these changes
Apr 4, 2017
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM insofar I'm able to judge that.
hybrist
commented
Apr 4, 2017
CollaboratorAuthor
Thanks! Passes on latest nightly & 7.x, merging. |
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested against nodejs/node#11431.
On versions of node that don't use the new protocol by default, this test is skipped (and the feature will most likely not work).