Skip to content

Commit 00b0a62

Browse files
MaleDongtargos
authored andcommitted
zlib: remove unused parameters
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: #22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 193a048 commit 00b0a62

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎lib/zlib.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {
198198
throwerr;
199199
}
200200

201-
// 1. Returns def for undefined and NaN
201+
// 1. Returns def for number when it's undefined or NaN
202202
// 2. Returns number for finite numbers >= lower and <= upper
203203
// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
204204
// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
205205
functioncheckRangesOrGetDefault(number,name,lower,upper,def){
206-
if(!checkFiniteNumber(number,name,lower,upper)){
206+
if(!checkFiniteNumber(number,name)){
207207
returndef;
208208
}
209209
if(number<lower||number>upper){

0 commit comments

Comments
 (0)