Uh oh!
There was an error while loading. Please reload this page.
Closed
Conversation
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation.
Trott
commented
Aug 4, 2018
Member
ghost
commented
Aug 4, 2018
Author
cjihrig
approved these changes
Aug 4, 2018
maclover7
approved these changes
Aug 4, 2018
lpinca
approved these changes
Aug 4, 2018
jasnell
approved these changes
Aug 6, 2018
Trott
commented
Aug 6, 2018
Member
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16240/ |
trivikr
approved these changes
Aug 7, 2018
trivikr
commented
Aug 7, 2018
Member
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16244/ |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 7, 2018
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: nodejs#22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott
commented
Aug 7, 2018
Member
Landed in 493e6d4 |
ghost
deleted the
zlibUselessParams
branch
August 8, 2018 00:43
ghost
commented
Aug 8, 2018
Author
Thanks! |
targos pushed a commit
that referenced
this pull request
Aug 11, 2018
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: #22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
firass111 pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: nodejs/node#22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
checkRangesOrGetDefaultcallscheckFiniteNumber, the latterfunction only has two parameters, so
lowerandupperdon't need tobe passed for validation.
make -j4 test(UNIX), orvcbuild test(Windows) passes