repl: add new language features to top level await statements

BridgeAR · targos · commit 01d632d7e8cf · 2019-04-30T17:47:28.000+02:00
This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL. PR-URL: #27400 Refs: #27391 Refs: #25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/lib/internal/repl/await.js b/lib/internal/repl/await.js
@@ -4,6 +4,23 @@ const { Object } = primordials;
 
 const acorn = require('internal/deps/acorn/acorn/dist/acorn');
 const walk = require('internal/deps/acorn/acorn-walk/dist/walk');
+const privateMethods =
+ require('internal/deps/acorn-plugins/acorn-private-methods/index');
+const bigInt = require('internal/deps/acorn-plugins/acorn-bigint/index');
+const classFields =
+ require('internal/deps/acorn-plugins/acorn-class-fields/index');
+const numericSeparator =
+ require('internal/deps/acorn-plugins/acorn-numeric-separator/index');
+const staticClassFeatures =
+ require('internal/deps/acorn-plugins/acorn-static-class-features/index');
+
+const parser = acorn.Parser.extend(
+ privateMethods,
+ bigInt,
+ classFields,
+ numericSeparator,
+ staticClassFeatures
+);
 
 const noop = () => {};
 const visitorsWithoutAncestors = {
@@ -76,7 +93,7 @@ function processTopLevelAwait(src) {
 const wrappedArray = wrapped.split('');
 let root;
 try {
- root = acorn.parse(wrapped, { ecmaVersion: 10 });
+ root = parser.parse(wrapped, { ecmaVersion: 10 });
 } catch {
 return null;
 }

-Original file line number
+Diff line change
 constacorn=require('internal/deps/acorn/acorn/dist/acorn');
 constwalk=require('internal/deps/acorn/acorn-walk/dist/walk');
 +constprivateMethods=
 +require('internal/deps/acorn-plugins/acorn-private-methods/index');
 +constbigInt=require('internal/deps/acorn-plugins/acorn-bigint/index');
 +constclassFields=
 +require('internal/deps/acorn-plugins/acorn-class-fields/index');
 +constnumericSeparator=
 +require('internal/deps/acorn-plugins/acorn-numeric-separator/index');
 +conststaticClassFeatures=
 +require('internal/deps/acorn-plugins/acorn-static-class-features/index');
++
 +constparser=acorn.Parser.extend(
 +privateMethods,
 +bigInt,
 +classFields,
 +numericSeparator,
 +staticClassFeatures
 +);
 constnoop=()=>{};
 constvisitorsWithoutAncestors={
 constwrappedArray=wrapped.split('');
 letroot;
 try{
 -root=acorn.parse(wrapped,{ecmaVersion: 10});
 +root=parser.parse(wrapped,{ecmaVersion: 10});
 }catch{
 returnnull;
+}