assert,deps,repl: fix repl and assert not being able to handle language features properly by BridgeAR · Pull Request #27400 · nodejs/node

BridgeAR · 2019-04-24T22:21:23Z

This adds a acorn plugins to properly handle stage-3 language features in the REPL and assert.

I stripped the plugins to the minimum and also removed a couple of files that we will not use to reduce our code overhead in core.

I had to change the require calls in the plugins to work properly with core but I guess that's expected.

The numeric separators are not yet supported by V8 but it should be supported by v7.5, so adding it now makes this feature available from the moment we include the new version.

There are a few more plugins for other language features: acorn-dynamic-import, acorn-import-meta and acorn-export-ns-from. These are all @nodejs/modules related and I am not sure if we should include these as well or not. I felt these are not suitable for us but I might be wrong?

We currently include the main acorn license file which states Copyright (C) 2012-2018 by various contributors (see AUTHORS). The plugin licenses are also MIT licenses but it states Copyright (C) 2017-2018 by Adrian Heine. I am not sure if the various contributors would be sufficient here, since this is a single person for these modules even though they are hosted in the acornjs organization.
If we have to pull in the other licenses, should I move the plugins out into another folder so that we use a single license for all plugins together (they are all written by the same person / have the same license) or should we include all licenses individually?

Fixes: #27391
Fixes: #25835

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This adds bigint, class-fields, numeric-separators, static-class features, private class methods and fields as dependency. That way it's possible to use these in combination with acorn to parse these language features. This also removes a couple of files that were not necessary for Node.js to reduce the code base.

This adds new language features to acorn. Otherwise BigInt and other input would not be parsed correct and would not result in nice error messages when using simple assert.

This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL.

This adds stage-3 language features to acorn so that the REPL is able to parse these features properly. Otherwise these would cause SyntaxErrors.

nodejs-github-bot · 2019-04-24T22:21:25Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3360

GeoffreyBooth · 2019-04-24T22:26:42Z

@BridgeAR Take a look at nodejs/ecmascript-modules#69. I was working around the lack of import() support in Acorn for that PR, so having such support would be nice (but not required).

BridgeAR · 2019-04-24T22:34:12Z

@GeoffreyBooth I suggest that you add the necessary Plugin to your PR but I am not sure if it's necessary for assert or the REPL to have support for this.

nodejs-github-bot · 2019-04-24T23:28:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22701/

nodejs-github-bot · 2019-04-25T04:24:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22706/

BridgeAR · 2019-04-26T16:12:14Z

@nodejs/tsc PTAL about the licensing questions (see #27400 (comment)).

@nodejs/assert @nodejs/repl PTAL

targos · 2019-04-26T16:42:17Z

My suggestion regarding the license:

Move all acorn plugins to a new directory: deps/acorn-plugins
targos@6d8e444

BridgeAR · 2019-04-26T17:07:50Z

@targos I incorporated your suggestion.

nodejs-github-bot · 2019-04-26T17:08:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22734/

targos · 2019-04-26T17:45:38Z

Can you run tools/license-builder.sh and commit the updated license file?

This adds new language features to acorn. Otherwise BigInt and other input would not be parsed correct and would not result in nice error messages when using simple assert. PR-URL: nodejs#27400 Refs: nodejs#27391 Refs: nodejs#25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL. PR-URL: nodejs#27400 Refs: nodejs#27391 Refs: nodejs#25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

This adds stage-3 language features to acorn so that the REPL is able to parse these features properly. Otherwise these would cause SyntaxErrors. PR-URL: nodejs#27400Fixes: nodejs#27391Fixes: nodejs#25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: nodejs#27400 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR · 2019-04-30T14:23:40Z

Thanks for the reviews.

Landed in 98e9de7...3d2409c 🎉

This adds bigint, class-fields, numeric-separators, static-class features, private class methods and fields as dependency. That way it's possible to use these in combination with acorn to parse these language features. This also removes a couple of files that were not necessary for Node.js to reduce the code base. PR-URL: #27400 Refs: #27391 Refs: #25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

This adds new language features to acorn. Otherwise BigInt and other input would not be parsed correct and would not result in nice error messages when using simple assert. PR-URL: #27400 Refs: #27391 Refs: #25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL. PR-URL: #27400 Refs: #27391 Refs: #25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

This adds stage-3 language features to acorn so that the REPL is able to parse these features properly. Otherwise these would cause SyntaxErrors. PR-URL: #27400Fixes: #27391Fixes: #25835 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #27400 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Notable changes: * deps: * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP parser refuse any request URL that contained the "|" (vertical bar) character. #27595 * tls: * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace` option to `tls.createServer()`. When enabled, TSL packet trace information is written to `stderr`. This can be used to debug TLS connection problems. #27497 #27376 * cli: * Added a `--trace-tls` command-line flag that enables tracing of TLS connections without the need to modify existing application code. #27497 * Added a `--cpu-prof-interval` command-line flag. It can be used to specify the sampling interval for the CPU profiles generated by `--cpu-prof`. #27535 * module: * Added the `createRequire()` method. It allows to create a require function from a file URL object, a file URL string or an absolute path string. The existing `createRequireFromPath()` method is now deprecated #27405. * Throw on `require('./path.mjs')`. This is technically a breaking change that should have landed with Node.js 12.0.0. It is necessary to have this to keep the possibility for a future minor version to load ES Modules with the require function. #27417 * repl: * The REPL now supports multi-line statements using `BigInt` literals as well as public and private class fields and methods. #27400 * The REPL now supports tab autocompletion of file paths with `fs` methods. #26648 * meta: * Added Christian Clauss (https://github.com/cclauss) to collaborators. #27554 PR-URL: #27578

BridgeAR added 4 commits April 24, 2019 23:57

assert: use new language features
5bfaab3
This adds new language features to acorn. Otherwise BigInt and other input would not be parsed correct and would not result in nice error messages when using simple assert.

repl: add new language features to top level await statements
dd3f9b1
This adds stage-3 language features to acorn so that it's possible to parse these features when using top level await in the REPL.

repl: handle stage-3 language features properly
39a5a38
This adds stage-3 language features to acorn so that the REPL is able to parse these features properly. Otherwise these would cause SyntaxErrors.

test: add tests for new language features
c3c18a1

This comment has been minimized.
Sign in to view

BridgeAR added assert Issues and PRs related to the assert subsystem. repl Issues and PRs related to the REPL subsystem. labels Apr 24, 2019

jasnell reviewed Apr 25, 2019
View reviewed changes

Comment threadtest/parallel/test-assert.js

fixup! test: add tests for new language features
022aa35

BridgeAR requested review from Fishrock123, mcollina and targos April 25, 2019 08:41

targos reviewed Apr 26, 2019
View reviewed changes

Comment threadlib/assert.js Outdated

BridgeAR added 4 commits April 26, 2019 19:06

fixup! deps: add acorn stage-3 plugins
7a94f40

fixup! assert: use new language features
172d4be

fixup! repl: add new language features to top level await statements
a4151f0

fixup! repl: handle stage-3 language features properly
4ed5e0b

This comment has been minimized.
Sign in to view

fixup! deps: add acorn stage-3 plugins
bc81720

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 30, 2019
test: add tests for new language features
3d2409c
PR-URL: nodejs#27400 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

BridgeAR closed this Apr 30, 2019

targos pushed a commit that referenced this pull request Apr 30, 2019
test: add tests for new language features
fefbbd9
PR-URL: #27400 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos mentioned this pull request May 6, 2019
v12.2.0 proposal #27578
Merged

GeoffreyBooth mentioned this pull request May 19, 2019
Utility method for detecting ES module syntax nodejs/ecmascript-modules#69
Closed

BridgeAR deleted the fix-repl-and-more branch January 20, 2020 12:03

mscdex mentioned this pull request Feb 22, 2020
repl: SyntaxError thrown when entering bigint literal inside multi-line input #31919
Closed

mscdex added the backport-requested-v10.x label Feb 23, 2020

targos added dont-land-on-v10.x and removed backport-requested-v10.x labels Jul 16, 2020

Uh oh!

Uh oh!

Conversation

BridgeAR commented Apr 24, 2019

Checklist

Uh oh!

nodejs-github-bot commented Apr 24, 2019

Uh oh!

GeoffreyBooth commented Apr 24, 2019

Uh oh!

BridgeAR commented Apr 24, 2019

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Apr 24, 2019

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 25, 2019

Uh oh!

BridgeAR commented Apr 26, 2019

Uh oh!

targos commented Apr 26, 2019

Uh oh!

Uh oh!

BridgeAR commented Apr 26, 2019

Uh oh!

nodejs-github-bot commented Apr 26, 2019

Uh oh!

targos commented Apr 26, 2019

Uh oh!

This comment has been minimized.

BridgeAR commented Apr 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants