test: refactor test-fs-utimes

* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: #9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: jun-oka

test/parallel/test-fs-utimes.js

@@ -4,11 +4,11 @@ var assert = require('assert');
 varutil=require('util');
 varfs=require('fs');
 
-vartests_ok=0;
-vartests_run=0;
+lettests_ok=0;
+lettests_run=0;
 
 functionstat_resource(resource){
-if(typeofresource=='string'){
+if(typeofresource==='string'){
 returnfs.statSync(resource);
 }else{
 // ensure mtime has been written to disk
@@ -19,8 +19,8 @@ function stat_resource(resource) {
 
 functioncheck_mtime(resource,mtime){
 mtime=fs._toUnixTimestamp(mtime);
-varstats=stat_resource(resource);
-varreal_mtime=fs._toUnixTimestamp(stats.mtime);
+conststats=stat_resource(resource);
+constreal_mtime=fs._toUnixTimestamp(stats.mtime);
 // check up to single-second precision
 // sub-second precision is OS and fs dependant
 returnmtime-real_mtime<2;
@@ -46,9 +46,9 @@ function expect_ok(syscall, resource, err, atime, mtime) {
 // the tests assume that __filename belongs to the user running the tests
 // this should be a fairly safe assumption; testing against a temp file
 // would be even better though (node doesn't have such functionality yet)
-functionrunTest(atime,mtime,callback){
+functiontestIt(atime,mtime,callback){
 
-varfd;
+letfd;
 //
 // test synchronized code paths, these functions throw on failure
 //
@@ -67,8 +67,7 @@ function runTest(atime, mtime, callback) {
 expect_errno('futimesSync',fd,ex,'ENOSYS');
 }
 
-varerr;
-err=undefined;
+leterr=undefined;
 try{
 fs.utimesSync('foobarbaz',atime,mtime);
 }catch(ex){
@@ -90,10 +89,10 @@ function runTest(atime, mtime, callback) {
 //
 // test async code paths
 //
-fs.utimes(__filename,atime,mtime,function(err){
+fs.utimes(__filename,atime,mtime,common.mustCall(function(err){
 expect_ok('utimes',__filename,err,atime,mtime);
 
-fs.utimes('foobarbaz',atime,mtime,function(err){
+fs.utimes('foobarbaz',atime,mtime,common.mustCall(function(err){
 expect_errno('utimes','foobarbaz',err,'ENOENT');
 
 // don't close this fd
@@ -103,34 +102,36 @@ function runTest(atime, mtime, callback) {
 fd=fs.openSync(__filename,'r');
 }
 
-fs.futimes(fd,atime,mtime,function(err){
+fs.futimes(fd,atime,mtime,common.mustCall(function(err){
 expect_ok('futimes',fd,err,atime,mtime);
 
-fs.futimes(-1,atime,mtime,function(err){
+fs.futimes(-1,atime,mtime,common.mustCall(function(err){
 expect_errno('futimes',-1,err,'EBADF');
 syncTests();
 callback();
-});
+}));
 tests_run++;
-});
+}));
 tests_run++;
-});
+}));
 tests_run++;
-});
+}));
 tests_run++;
 }
 
-varstats=fs.statSync(__filename);
+conststats=fs.statSync(__filename);
 
 // run tests
+construnTest=common.mustCall(testIt,6);
+
 runTest(newDate('1982-09-10 13:37'),newDate('1982-09-10 13:37'),function(){
 runTest(newDate(),newDate(),function(){
 runTest(123456.789,123456.789,function(){
 runTest(stats.mtime,stats.mtime,function(){
 runTest(NaN,Infinity,function(){
-runTest('123456',-1,function(){
+runTest('123456',-1,common.mustCall(function(){
 // done
-});
+}));
 });
 });
 });
@@ -140,5 +141,5 @@ runTest(new Date('1982-09-10 13:37'), new Date('1982-09-10 13:37'), function() {
 
 process.on('exit',function(){
 console.log('Tests run / ok:',tests_run,'/',tests_ok);
-assert.equal(tests_ok,tests_run);
+assert.strictEqual(tests_ok,tests_run);
 });