Skip to content

test: favor === over == in fs-utimes - #9290

Closed
jun-oka wants to merge 2 commits into
nodejs:masterfrom
jun-oka:test-fs-utimes-eqeqeq
Closed

test: favor === over == in fs-utimes#9290
jun-oka wants to merge 2 commits into
nodejs:masterfrom
jun-oka:test-fs-utimes-eqeqeq

Conversation

@jun-oka

@jun-okajun-oka commented Oct 26, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs-utimes

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2016
@cjihrig

cjihrig commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

This is a good start, but there are other improvements that can be made while you're updating this test:

  • Replace var with const where appropriate.
  • Use common.mustCall() and common.fail() to enforce execution flow.
  • It might be possible to get rid of tests_run, tests_ok, and the process.on('exit', ...), but this would require more digging.

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 26, 2016
@jun-oka

jun-oka commented Oct 26, 2016

Copy link
Copy Markdown
ContributorAuthor

@cjihrig Sorry, I overlooked var and const one before I commit. Thank you for common.mustCall() and common.fail() info! I will handle it today.

@Trott

Trott commented Oct 26, 2016

Copy link
Copy Markdown
Member

I'd also add that if you do end up keeping the assert.equal(), it would be great if it were possible to use assert.strictEqual() instead.

@jun-oka

jun-oka commented Oct 26, 2016

Copy link
Copy Markdown
ContributorAuthor

@Trott Understood. I found it on Line 143. Thank you.

@jun-oka
jun-okaforce-pushed the test-fs-utimes-eqeqeq branch from 9c93f6c to 8133444CompareDecember 24, 2016 18:08
@jun-oka

jun-oka commented Dec 24, 2016

Copy link
Copy Markdown
ContributorAuthor

@cjihrig@Trott I have corrected those issue. Thanks a lot!

@Trott

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5575/

@Trott

Trott commented Jan 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5742/

@Trott
Trottforce-pushed the test-fs-utimes-eqeqeq branch from 8133444 to 90b88b9CompareJanuary 7, 2017 00:02
@Trott

Trott commented Jan 7, 2017

Copy link
Copy Markdown
Member

Landed in 377ea28.
Thanks for the contribution! 🎉

@TrottTrott closed this Jan 7, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 7, 2017
@jun-oka@Trott
test: refactor test-fs-utimes
377ea28
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: nodejs#9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@jun-okaItalo A. Casas
test: refactor test-fs-utimes
cc1af2b
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: nodejs#9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@jun-okaItalo A. Casas
test: refactor test-fs-utimes
4990feb
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: nodejs#9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@jun-okaItalo A. Casas
test: refactor test-fs-utimes
146d231
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: nodejs#9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@jun-okaItalo A. Casas
test: refactor test-fs-utimes
38bdfb0
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: nodejs#9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@jun-oka@MylesBorins
test: refactor test-fs-utimes
a0f1b23
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: #9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@jun-oka@MylesBorins
test: refactor test-fs-utimes
50523dd
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: #9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@jun-oka@MylesBorins
test: refactor test-fs-utimes
12746af
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: #9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@jun-oka@MylesBorins
test: refactor test-fs-utimes
3f3c78d
* favor `===` over `==`
* `var` -> `const`/`let`
* use `common.mustCall()`
PR-URL: #9290
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jun-oka@cjihrig@Trott@jasnell@targos@mscdex@MylesBorins@nodejs-github-bot