inspector: fix compressed responses

PR-URL: #61226Fixes: #61222
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

Author: rubnogueira

lib/internal/inspector/network.js

@@ -10,8 +10,15 @@ const {
 constdc=require('diagnostics_channel');
 const{ now }=require('internal/perf/utils');
 const{ MIMEType }=require('internal/mime');
+const{
+ createGunzip,
+ createInflate,
+ createBrotliDecompress,
+ createZstdDecompress,
+}=require('zlib');
 
 constkInspectorRequestId=Symbol('kInspectorRequestId');
+constkContentEncoding=Symbol('kContentEncoding');
 
 // https://chromedevtools.github.io/devtools-protocol/1-3/Network/#type-ResourceType
 constkResourceType={
@@ -70,6 +77,27 @@ function sniffMimeType(contentType) {
 };
 }
 
+/**
+ * Creates a decompression stream based on the content encoding.
+ * @param {string} encoding - The content encoding (e.g., 'gzip', 'deflate', 'br', 'zstd').
+ * @returns {import('stream').Transform|null} - A decompression stream or null if encoding is not supported.
+ */
+functioncreateDecompressor(encoding){
+switch(encoding){
+case'gzip':
+case'x-gzip':
+returncreateGunzip();
+case'deflate':
+returncreateInflate();
+case'br':
+returncreateBrotliDecompress();
+case'zstd':
+returncreateZstdDecompress();
+default:
+returnnull;
+}
+}
+
 functionregisterDiagnosticChannels(listenerPairs){
 functionenable(){
 ArrayPrototypeForEach(listenerPairs,({0: channel,1: listener})=>{
@@ -91,9 +119,11 @@ function registerDiagnosticChannels(listenerPairs) {
 
 module.exports={
  kInspectorRequestId,
+ kContentEncoding,
  kResourceType,
  getMonotonicTime,
  getNextRequestId,
  registerDiagnosticChannels,
  sniffMimeType,
+ createDecompressor,
 };

lib/internal/inspector/network_http.js

@@ -10,11 +10,13 @@ const {
 
 const{
  kInspectorRequestId,
+ kContentEncoding,
  kResourceType,
  getMonotonicTime,
  getNextRequestId,
  registerDiagnosticChannels,
  sniffMimeType,
+ createDecompressor,
 }=require('internal/inspector/network');
 const{ Network }=require('inspector');
 constEventEmitter=require('events');
@@ -27,6 +29,7 @@ const convertHeaderObject = (headers = {}) => {
 lethost;
 letcharset;
 letmimeType;
+letcontentEncoding;
 constdict={};
 for(const{0: key,1: value}ofObjectEntries(headers)){
 constlowerCasedKey=key.toLowerCase();
@@ -38,6 +41,9 @@ const convertHeaderObject = (headers = {}) => {
 charset=result.charset;
 mimeType=result.mimeType;
 }
+if(lowerCasedKey==='content-encoding'){
+contentEncoding=typeofvalue==='string' ? value.toLowerCase() : undefined;
+}
 if(typeofvalue==='string'){
 dict[key]=value;
 }elseif(ArrayIsArray(value)){
@@ -50,7 +56,7 @@ const convertHeaderObject = (headers = {}) => {
 dict[key]=String(value);
 }
 }
-return[dict,host,charset,mimeType];
+return[dict,host,charset,mimeType,contentEncoding];
 };
 
 /**
@@ -105,7 +111,10 @@ function onClientResponseFinish({ request, response }) {
 return;
 }
 
-const{0: headers,2: charset,3: mimeType}=convertHeaderObject(response.headers);
+const{0: headers,2: charset,3: mimeType,4: contentEncoding}=convertHeaderObject(response.headers);
+
+// Store content encoding on the request for later use
+request[kContentEncoding]=contentEncoding;
 
 Network.responseReceived({
 requestId: request[kInspectorRequestId],
@@ -121,24 +130,64 @@ function onClientResponseFinish({ request, response }) {
 },
 });
 
-// Unlike response.on('data', ...), this does not put the stream into flowing mode.
-EventEmitter.prototype.on.call(response,'data',(chunk)=>{
-Network.dataReceived({
-requestId: request[kInspectorRequestId],
-timestamp: getMonotonicTime(),
-dataLength: chunk.byteLength,
-encodedDataLength: chunk.byteLength,
-data: chunk,
+// Create a decompressor if the response is compressed
+constdecompressor=createDecompressor(contentEncoding);
+
+if(decompressor){
+// Pipe decompressed data to DevTools
+decompressor.on('data',(decompressedChunk)=>{
+Network.dataReceived({
+requestId: request[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+dataLength: decompressedChunk.byteLength,
+encodedDataLength: decompressedChunk.byteLength,
+data: decompressedChunk,
+});
 });
-});
 
-// Wait until the response body is consumed by user code.
-response.once('end',()=>{
-Network.loadingFinished({
-requestId: request[kInspectorRequestId],
-timestamp: getMonotonicTime(),
+// Handle decompression errors gracefully - fall back to raw data
+decompressor.on('error',()=>{
+// If decompression fails, the raw data has already been sent via the fallback
 });
-});
+
+// Unlike response.on('data', ...), this does not put the stream into flowing mode.
+EventEmitter.prototype.on.call(response,'data',(chunk)=>{
+// Feed the chunk into the decompressor
+decompressor.write(chunk);
+});
+
+// Wait until the response body is consumed by user code.
+response.once('end',()=>{
+// End the decompressor stream
+decompressor.end();
+decompressor.once('end',()=>{
+Network.loadingFinished({
+requestId: request[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+});
+});
+});
+}else{
+// No decompression needed, send data directly
+// Unlike response.on('data', ...), this does not put the stream into flowing mode.
+EventEmitter.prototype.on.call(response,'data',(chunk)=>{
+Network.dataReceived({
+requestId: request[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+dataLength: chunk.byteLength,
+encodedDataLength: chunk.byteLength,
+data: chunk,
+});
+});
+
+// Wait until the response body is consumed by user code.
+response.once('end',()=>{
+Network.loadingFinished({
+requestId: request[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+});
+});
+}
 }
 
 module.exports=registerDiagnosticChannels([

lib/internal/inspector/network_http2.js

@@ -10,15 +10,18 @@ const {
 
 const{
  kInspectorRequestId,
+ kContentEncoding,
  kResourceType,
  getMonotonicTime,
  getNextRequestId,
  registerDiagnosticChannels,
  sniffMimeType,
+ createDecompressor,
 }=require('internal/inspector/network');
 const{ Network }=require('inspector');
 const{
 HTTP2_HEADER_AUTHORITY,
+HTTP2_HEADER_CONTENT_ENCODING,
 HTTP2_HEADER_CONTENT_TYPE,
 HTTP2_HEADER_COOKIE,
 HTTP2_HEADER_METHOD,
@@ -42,6 +45,7 @@ function convertHeaderObject(headers = {}) {
 letstatusCode;
 letcharset;
 letmimeType;
+letcontentEncoding;
 constdict={};
 
 for(const{0: key,1: value}ofObjectEntries(headers)){
@@ -61,6 +65,8 @@ function convertHeaderObject(headers = {}) {
 constresult=sniffMimeType(value);
 charset=result.charset;
 mimeType=result.mimeType;
+}elseif(lowerCasedKey===HTTP2_HEADER_CONTENT_ENCODING){
+contentEncoding=typeofvalue==='string' ? value.toLowerCase() : undefined;
 }
 
 if(typeofvalue==='string'){
@@ -78,7 +84,7 @@ function convertHeaderObject(headers = {}) {
 
 consturl=`${scheme}://${authority}${path}`;
 
-return[dict,url,method,statusCode,charset,mimeType];
+return[dict,url,method,statusCode,charset,mimeType,contentEncoding];
 }
 
 /**
@@ -194,7 +200,16 @@ function onClientStreamFinish({ stream, headers }) {
 return;
 }
 
-const{0: convertedHeaderObject,3: statusCode,4: charset,5: mimeType}=convertHeaderObject(headers);
+const{
+0: convertedHeaderObject,
+3: statusCode,
+4: charset,
+5: mimeType,
+6: contentEncoding,
+}=convertHeaderObject(headers);
+
+// Store content encoding on the stream for later use
+stream[kContentEncoding]=contentEncoding;
 
 Network.responseReceived({
 requestId: stream[kInspectorRequestId],
@@ -210,23 +225,56 @@ function onClientStreamFinish({ stream, headers }) {
 },
 });
 
-// Unlike stream.on('data', ...), this does not put the stream into flowing mode.
-EventEmitter.prototype.on.call(stream,'data',(chunk)=>{
-/**
- * When a chunk of the response body has been received, cache it until `getResponseBody` request
- * https://chromedevtools.github.io/devtools-protocol/1-3/Network/#method-getResponseBody or
- * stream it with `streamResourceContent` request.
- * https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-streamResourceContent
- */
-
-Network.dataReceived({
-requestId: stream[kInspectorRequestId],
-timestamp: getMonotonicTime(),
-dataLength: chunk.byteLength,
-encodedDataLength: chunk.byteLength,
-data: chunk,
+// Create a decompressor if the response is compressed
+constdecompressor=createDecompressor(contentEncoding);
+
+if(decompressor){
+// Pipe decompressed data to DevTools
+decompressor.on('data',(decompressedChunk)=>{
+Network.dataReceived({
+requestId: stream[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+dataLength: decompressedChunk.byteLength,
+encodedDataLength: decompressedChunk.byteLength,
+data: decompressedChunk,
+});
 });
-});
+
+// Handle decompression errors gracefully
+decompressor.on('error',()=>{
+// If decompression fails, the raw data has already been sent via the fallback
+});
+
+// Unlike stream.on('data', ...), this does not put the stream into flowing mode.
+EventEmitter.prototype.on.call(stream,'data',(chunk)=>{
+// Feed the chunk into the decompressor
+decompressor.write(chunk);
+});
+
+// End the decompressor when the stream closes
+stream.once('end',()=>{
+decompressor.end();
+});
+}else{
+// No decompression needed, send data directly
+// Unlike stream.on('data', ...), this does not put the stream into flowing mode.
+EventEmitter.prototype.on.call(stream,'data',(chunk)=>{
+/**
+ * When a chunk of the response body has been received, cache it until `getResponseBody` request
+ * https://chromedevtools.github.io/devtools-protocol/1-3/Network/#method-getResponseBody or
+ * stream it with `streamResourceContent` request.
+ * https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-streamResourceContent
+ */
+
+Network.dataReceived({
+requestId: stream[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+dataLength: chunk.byteLength,
+encodedDataLength: chunk.byteLength,
+data: chunk,
+});
+});
+}
 }
 
 /**