Uh oh!
There was an error while loading. Please reload this page.
inspector: fix compressed responses - #61226
Conversation
nodejs-github-bot
commented
Dec 30, 2025
Review requested:
|
rubnogueira
commented
Dec 30, 2025
Tagging you @legendecas because I saw some of your work on the inspector. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #61226 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 704 704 Lines 208734 208866 +132 Branches 40271 40300 +29 ==========================================
+ Hits 184823 184927 +104 - Misses 15932 15945 +13 - Partials 7979 7994 +15
🚀 New features to boost your workflow:
|
rubnogueira
commented
Dec 31, 2025
I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines. Please let me know if something is missing since it's my first contribution in this repo. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rubnogueira
commented
Jan 14, 2026
@legendecas can you please review my last changes? thanks! |
nodejs-github-bot
commented
Jan 14, 2026
nodejs-github-bot
commented
Jan 19, 2026
nodejs-github-bot
commented
Jan 20, 2026
Commit Queue failed- Loading data for nodejs/node/pull/61226 ✔ Done loading data for nodejs/node/pull/61226 ----------------------------------- PR info ------------------------------------ Title inspector: fix compressed responses (#61226) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rubnogueira:main -> nodejs:main Labels http, inspector, http2, author ready, needs-ci, commit-queue-squash Commits 5 - inspector: fix compressed responses - inspector: lint code - inspector: remove irrelevant code - inspector: remove irrelevant file - inspector: fix tests and inline Committers 1 - Ruben Nogueira <ruben.p.nogueira@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61226 Fixes: https://github.com/nodejs/node/issues/61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61226 Fixes: https://github.com/nodejs/node/issues/61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 Dec 2025 20:14:26 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61226#pullrequestreview-3660965504 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/61226#pullrequestreview-3673245165 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-01-19T18:02:47Z: https://ci.nodejs.org/job/node-test-pull-request/70893/ - Querying data for job/node-test-pull-request/70893/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187587953 |
legendecas
commented
Jan 22, 2026
Landed in 186c7a9 |
aduh95
commented
Jan 24, 2026
This PR introduced a flaky test, too bad #61226 (comment) was resumed despite showing the added test failing. I've opened a revert in #61502. |
PR-URL: nodejs#61226Fixes: nodejs#61222 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
fix: #61222
Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.
This PR implements proper compression decryption if the
content-encodingheader is returned in the response headers.Repro here: https://github.com/rubnogueira/nodejs-repro-61222