dgram: fix unhandled exception aborting a closed udp socket

vramana · targos · commit 247dfb7d73e1 · 2023-03-13T14:55:05.000+01:00
Fixes: #46750 PR-URL: #46770 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -139,7 +139,7 @@ function Socket(type, listener) {
 const { signal } = options;
 validateAbortSignal(signal, 'options.signal');
 const onAborted = () => {
- this.close();
+ if (this[kStateSymbol].handle) this.close();
 };
 if (signal.aborted) {
 onAborted();
diff --git a/test/parallel/test-dgram-abort-closed.js b/test/parallel/test-dgram-abort-closed.js
@@ -0,0 +1,10 @@
+'use strict';
+require('../common');
+const dgram = require('dgram');
+
+const controller = new AbortController();
+const socket = dgram.createSocket({ type: 'udp4', signal: controller.signal });
+
+socket.close();
+
+controller.abort();

-Original file line number
+Diff line change
 const{ signal }=options;
 validateAbortSignal(signal,'options.signal');
 constonAborted=()=>{
 -this.close();
 +if(this[kStateSymbol].handle)this.close();
 };
 if(signal.aborted){
 onAborted();