Skip to content

dgram: fix unhandled exception aborting a closed udp socket - #46770

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vramana:fix-dgram
Feb 25, 2023
Merged

dgram: fix unhandled exception aborting a closed udp socket#46770
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vramana:fix-dgram

Conversation

@vramana

@vramanavramana commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Fixes: #46750

@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Feb 22, 2023
@ShogunPanda

ShogunPanda commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Can you please add a test for this?

@vramana

vramana commented Feb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@ShogunPanda Does this suffice?

cjihrig
cjihrig reviewed Feb 22, 2023
View reviewed changes
Comment threadtest/parallel/test-dgram-abort-closed.js Outdated
mcollina
mcollina approved these changes Feb 22, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cjihrig
cjihrig approved these changes Feb 23, 2023
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@ShogunPanda

ShogunPanda commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

@ShogunPanda Does this suffice?

Absolutely, thanks!

LGTM!

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@github-actionsgithub-actionsBot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49988/

@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2023
Open
28 tasks
@theanarkhtheanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 65d2a42 into nodejs:mainFeb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 65d2a42

@vramana
vramana deleted the fix-dgram branch February 25, 2023 16:13
@github-actionsgithub-actionsBot mentioned this pull request Feb 26, 2023
Open
15 tasks
This was referenced Feb 27, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@vramana@targos
dgram: fix unhandled exception aborting a closed udp socket
247dfb7
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@vramana@danielleadams
dgram: fix unhandled exception aborting a closed udp socket
8646b06
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dgramIssues and PRs related to the dgram subsystem / UDP.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Closing UDP socket with abort signal can lead to uncaught exception

9 participants

@vramana@nodejs-github-bot@ShogunPanda@mcollina@jasnell@cjihrig@BridgeAR@debadree25@theanarkh