bootstrap: refactor to use more primordials

PR-URL: #35999
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

Author: aduh95

lib/internal/bootstrap/loaders.js

@@ -44,15 +44,18 @@
 /* global process, getLinkedBinding, getInternalBinding, primordials */
 
 const{
+ ArrayPrototypeMap,
+ ArrayPrototypePush,
  Error,
- Map,
  ObjectCreate,
  ObjectDefineProperty,
  ObjectKeys,
  ObjectPrototypeHasOwnProperty,
  ReflectGet,
+ SafeMap,
  SafeSet,
  String,
+ StringPrototypeStartsWith,
  TypeError,
 }=primordials;
 
@@ -135,7 +138,7 @@ let internalBinding;
 letmod=bindingObj[module];
 if(typeofmod!=='object'){
 mod=bindingObj[module]=getInternalBinding(module);
-moduleLoadList.push(`Internal Binding ${module}`);
+ArrayPrototypePush(moduleLoadList,`Internal Binding ${module}`);
 }
 returnmod;
 };
@@ -163,12 +166,14 @@ class NativeModule {
  * A map from the module IDs to the module instances.
  * @type {Map<string, NativeModule>}
  */
-staticmap=newMap(moduleIds.map((id)=>[id,newNativeModule(id)]));
+staticmap=newSafeMap(
+ArrayPrototypeMap(moduleIds,(id)=>[id,newNativeModule(id)])
+);
 
 constructor(id){
 this.filename=`${id}.js`;
 this.id=id;
-this.canBeRequiredByUsers=!id.startsWith('internal/');
+this.canBeRequiredByUsers=!StringPrototypeStartsWith(id,'internal/');
 
 // The CJS exports object of the module.
 this.exports={};
@@ -221,7 +226,7 @@ class NativeModule {
 if(!this.exportKeys){
 // When using --expose-internals, we do not want to reflect the named
 // exports from core modules as this can trigger unnecessary getters.
-constinternal=this.id.startsWith('internal/');
+constinternal=StringPrototypeStartsWith(this.id,'internal/');
 this.exportKeys=internal ? [] : ObjectKeys(this.exports);
 }
 this.getESMFacade();
@@ -271,7 +276,7 @@ class NativeModule {
 this.loading=true;
 
 try{
-constrequireFn=this.id.startsWith('internal/deps/') ?
+constrequireFn=StringPrototypeStartsWith(this.id,'internal/deps/') ?
 requireWithFallbackInDeps : nativeModuleRequire;
 
 constfn=compileFunction(id);
@@ -282,7 +287,7 @@ class NativeModule {
 this.loading=false;
 }
 
-moduleLoadList.push(`NativeModule ${id}`);
+ArrayPrototypePush(moduleLoadList,`NativeModule ${id}`);
 returnthis.exports;
 }
 }

lib/internal/bootstrap/node.js

@@ -39,6 +39,7 @@
 setupPrepareStackTrace();
 
 const{
+ FunctionPrototypeCall,
  JSONParse,
  ObjectDefineProperty,
  ObjectGetPrototypeOf,
@@ -299,7 +300,7 @@ function setupProcessObject() {
 constEventEmitter=require('events');
 constorigProcProto=ObjectGetPrototypeOf(process);
 ObjectSetPrototypeOf(origProcProto,EventEmitter.prototype);
-EventEmitter.call(process);
+FunctionPrototypeCall(EventEmitter,process);
 ObjectDefineProperty(process,SymbolToStringTag,{
 enumerable: false,
 writable: true,

lib/internal/bootstrap/pre_execution.js

@@ -1,10 +1,11 @@
 'use strict';
 
 const{
- Map,
  NumberParseInt,
  ObjectDefineProperty,
+ SafeMap,
  SafeWeakMap,
+ StringPrototypeStartsWith,
 }=primordials;
 
 const{
@@ -96,7 +97,8 @@ function patchProcessObject(expandArgv1) {
 });
 process.argv[0]=process.execPath;
 
-if(expandArgv1&&process.argv[1]&&!process.argv[1].startsWith('-')){
+if(expandArgv1&&process.argv[1]&&
+!StringPrototypeStartsWith(process.argv[1],'-')){
 // Expand process.argv[1] into a full path.
 constpath=require('path');
 try{
@@ -357,7 +359,7 @@ function initializePolicy() {
 if(experimentalPolicy){
 process.emitWarning('Policies are experimental.',
 'ExperimentalWarning');
-const{ pathToFileURL,URL}=require('url');
+const{ pathToFileURL,URL}=require('internal/url');
 // URL here as it is slightly different parsing
 // no bare specifiers for now
 letmanifestURL;
@@ -374,7 +376,7 @@ function initializePolicy() {
 if(experimentalPolicyIntegrity){
 constSRI=require('internal/policy/sri');
 const{ createHash, timingSafeEqual }=require('crypto');
-constrealIntegrities=newMap();
+constrealIntegrities=newSafeMap();
 constintegrityEntries=SRI.parse(experimentalPolicyIntegrity);
 letfoundMatch=false;
 for(leti=0;i<integrityEntries.length;i++){