Uh oh!
There was an error while loading. Please reload this page.
bootstrap: refactor to use more primordials - #35999
Merged
Merged
Conversation
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
Review requested:
|
aduh95force-pushed
the
bootstrap-more-primordials
branch
from
November 6, 2020 15:16
249b816 to
df4d96cComparetargos
approved these changes
Nov 6, 2020
benjamingr
approved these changes
Nov 6, 2020
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Nov 6, 2020
Collaborator
PR-URL: nodejs#35999 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
aduh95force-pushed
the
bootstrap-more-primordials
branch
from
November 9, 2020 18:24
df4d96c to
b589128CompareContributorAuthor
Landed in b589128 |
danielleadams pushed a commit
that referenced
this pull request
Nov 10, 2020
PR-URL: #35999 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35999 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
BethGriggs pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35999 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35999 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
codebytere added a commit
to electron/electron
that referenced
this pull request
Feb 25, 2021
zcbenz pushed a commit
to electron/electron
that referenced
this pull request
Mar 1, 2021
* chore: bump node in DEPS to v14.16.0 * bootstrap: refactor to use more primordials nodejs/node#35999 * chore: update filenames list Co-authored-by: Electron Bot <electron@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes