v8: refactor to use more primordials

aduh95 · danielleadams · commit 2dd2ec38367a · 2021-01-12T07:07:53.000-05:00
PR-URL: #36527 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
diff --git a/lib/v8.js b/lib/v8.js
@@ -17,6 +17,8 @@
 const {
 Array,
 ArrayBuffer,
+ ArrayPrototypeForEach,
+ ArrayPrototypePush,
 DataView,
 Error,
 Float32Array,
@@ -191,13 +193,14 @@ const arrayBufferViewTypeToIndex = new SafeMap();
 
 {
 const dummy = new ArrayBuffer();
- for (const [i, ctor] of arrayBufferViewTypes.entries()) {
+ ArrayPrototypeForEach(arrayBufferViewTypes, (ctor, i) => {
 const tag = ObjectPrototypeToString(new ctor(dummy));
 arrayBufferViewTypeToIndex.set(tag, i);
- }
+ });
 }
 
-const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;
+const bufferConstructorIndex =
+ ArrayPrototypePush(arrayBufferViewTypes, FastBuffer) - 1;
 
 class DefaultSerializer extends Serializer {
 constructor() {

-Original file line number
+Diff line change
 const{
  Array,
  ArrayBuffer,
 + ArrayPrototypeForEach,
 + ArrayPrototypePush,
  DataView,
  Error,
  Float32Array,
+{
 constdummy=newArrayBuffer();
 -for(const[i,ctor]ofarrayBufferViewTypes.entries()){
 +ArrayPrototypeForEach(arrayBufferViewTypes,(ctor,i)=>{
 consttag=ObjectPrototypeToString(newctor(dummy));
 arrayBufferViewTypeToIndex.set(tag,i);
 -}
 +});
+}
 -constbufferConstructorIndex=arrayBufferViewTypes.push(FastBuffer)-1;
 +constbufferConstructorIndex=
 +ArrayPrototypePush(arrayBufferViewTypes,FastBuffer)-1;
 classDefaultSerializerextendsSerializer{
 constructor(){