Skip to content

v8: refactor to use more primordials - #36527

Closed
aduh95 wants to merge 3 commits into
nodejs:masterfrom
aduh95:v8-primordials
Closed

v8: refactor to use more primordials#36527
aduh95 wants to merge 3 commits into
nodejs:masterfrom
aduh95:v8-primordials

Conversation

@aduh95

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 15, 2020
@Trott

Copy link
Copy Markdown
Member

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@PoojaDurgadPoojaDurgad added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 17, 2020
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/761/

No impact on perf.

Details
 confidence improvement accuracy (*) (**) (***)
v8/get-stats.js n=1000000 method='getHeapSpaceStatistics' 0.70 % ±2.88% ±3.85% ±5.04%
v8/get-stats.js n=1000000 method='getHeapStatistics' 0.92 % ±1.63% ±2.17% ±2.83%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 2 comparisons, you can thus
expect the following amount of false-positive results:
0.10 false positives, when considering a 5% risk acceptance (*, **, ***),
0.02 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2020
@aduh95aduh95 mentioned this pull request Dec 18, 2020
4 tasks
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 80d2fbe...6091a65

nodejs-github-bot pushed a commit that referenced this pull request Dec 22, 2020
PR-URL: #36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@aduh95
aduh95 deleted the v8-primordials branch December 22, 2020 21:35
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
PR-URL: #36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@Trott@nodejs-github-bot@PoojaDurgad