stream: yield expected Error class on zlib errors

PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Author: panva

lib/internal/webstreams/adapters.js

@@ -1,13 +1,19 @@
 'use strict';
 
 const{
+ ArrayPrototypeFilter,
+ ArrayPrototypeMap,
+ Boolean,
+ ObjectEntries,
  PromisePrototypeThen,
  PromiseResolve,
  SafePromiseAll,
  SafePromisePrototypeFinally,
+ SafeSet,
  TypedArrayPrototypeGetBuffer,
- TypedArrayPrototypeGetByteOffset,
  TypedArrayPrototypeGetByteLength,
+ TypedArrayPrototypeGetByteOffset,
+ TypeError,
  Uint8Array,
 }=primordials;
 
@@ -82,6 +88,38 @@ const { UV_EOF } = internalBinding('uv');
 
 constencoder=newTextEncoder();
 
+// Collect all negative (error) ZLIB codes and Z_NEED_DICT
+constZLIB_FAILURES=newSafeSet([
+ ...ArrayPrototypeFilter(
+ArrayPrototypeMap(
+ObjectEntries(internalBinding('constants').zlib),
+({0: code,1: value})=>(value<0 ? code : null),
+),
+Boolean,
+),
+'Z_NEED_DICT',
+]);
+
+/**
+ * @param {Error|null} cause
+ * @returns {Error|null}
+ */
+functionhandleKnownInternalErrors(cause){
+switch(true){
+casecause?.code==='ERR_STREAM_PREMATURE_CLOSE': {
+returnnewAbortError(undefined,{ cause });
+}
+caseZLIB_FAILURES.has(cause?.code): {
+// eslint-disable-next-line no-restricted-syntax
+consterror=newTypeError(undefined,{ cause });
+error.code=cause.code;
+returnerror;
+}
+default:
+returncause;
+}
+}
+
 /**
  * @typedef {import('../../stream').Writable} Writable
  * @typedef {import('../../stream').Readable} Readable
@@ -137,10 +175,7 @@ function newWritableStreamFromStreamWritable(streamWritable) {
 }
 
 constcleanup=finished(streamWritable,(error)=>{
-if(error?.code==='ERR_STREAM_PREMATURE_CLOSE'){
-consterr=newAbortError(undefined,{cause: error});
-error=err;
-}
+error=handleKnownInternalErrors(error);
 
 cleanup();
 // This is a protection against non-standard, legacy streams
@@ -440,10 +475,7 @@ function newReadableStreamFromStreamReadable(streamReadable, options = kEmptyObj
 streamReadable.pause();
 
 constcleanup=finished(streamReadable,(error)=>{
-if(error?.code==='ERR_STREAM_PREMATURE_CLOSE'){
-consterr=newAbortError(undefined,{cause: error});
-error=err;
-}
+error=handleKnownInternalErrors(error);
 
 cleanup();
 // This is a protection against non-standard, legacy streams

test/wpt/status/compression.json

@@ -14,21 +14,8 @@
 "decompression-corrupt-input.tentative.any.js": {
 "fail": {
 "expected": [
-"truncating the input for 'deflate' should give an error",
 "trailing junk for 'deflate' should give an error",
-"format 'deflate' field CMF should be error for 0",
-"format 'deflate' field FLG should be error for 157",
-"format 'deflate' field DATA should be error for 5",
-"format 'deflate' field ADLER should be error for 255",
-"truncating the input for 'gzip' should give an error",
-"trailing junk for 'gzip' should give an error",
-"format 'gzip' field ID should be error for 255",
-"format 'gzip' field CM should be error for 0",
-"format 'gzip' field FLG should be error for 2",
-"format 'gzip' field DATA should be error for 3",
-"format 'gzip' field CRC should be error for 0",
-"format 'gzip' field ISIZE should be error for 1",
-"the deflate input compressed with dictionary should give an error"
+"trailing junk for 'gzip' should give an error"
  ]
  }
  },