Skip to content

stream: WPT fixes for Compression Streams - #50712

Closed
panva wants to merge 3 commits into
nodejs:mainfrom
panva:wpt-compression-fixes
Closed

stream: WPT fixes for Compression Streams#50712
panva wants to merge 3 commits into
nodejs:mainfrom
panva:wpt-compression-fixes

Conversation

@panva

@panvapanva commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Followup to #50631

  • adds the expected Symbol.toStringTag to CompressionStream and DecompressionStream
  • yields the expected error (TypeError) on corrupt inputs
  • updates the idlharness test files and expectations overall

@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 13, 2023
@panva

panva commented Nov 13, 2023

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/streams

@panvapanva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 13, 2023
@panva
panvaforce-pushed the wpt-compression-fixes branch from eaf6907 to 00a38f5CompareNovember 13, 2023 14:23
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Nov 13, 2023
View reviewed changes
Comment threadlib/internal/webstreams/adapters.js Outdated
Comment threadlib/internal/webstreams/adapters.js Outdated
Comment threadlib/internal/webstreams/adapters.js Outdated
ljharb
ljharb reviewed Nov 13, 2023
View reviewed changes
Comment threadlib/internal/webstreams/adapters.js Outdated
@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2023
Open
25 tasks
@panva
panvaforce-pushed the wpt-compression-fixes branch from f13ccd6 to 100f25cCompareNovember 14, 2023 08:45
@panva
panvaforce-pushed the wpt-compression-fixes branch from 100f25c to 74d8ee5CompareNovember 14, 2023 08:50
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55645/

@github-actionsgithub-actionsBot mentioned this pull request Nov 15, 2023
Open
26 tasks
@panva
panva requested review from anonrig and ljharbNovember 18, 2023 12:25
@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2023
mcollina
mcollina approved these changes Nov 18, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2023
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2023
@panva@nodejs-github-bot
test: update WPT files for WebIDL tests
e0bbe8f
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva
panva deleted the wpt-compression-fixes branch November 19, 2023 07:37
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
stream: add Symbol.toStringTag to Compression Streams
af9cd35
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
stream: yield expected Error class on zlib errors
1f9065d
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva@targos
test: update WPT files for WebIDL tests
b6c3cef
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panvaLei Shi
stream: add Symbol.toStringTag to Compression Streams
426ca12
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panvaLei Shi
stream: yield expected Error class on zlib errors
d899d5e
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panvaLei Shi
test: update WPT files for WebIDL tests
cbdf5a6
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
stream: add Symbol.toStringTag to Compression Streams
a275155
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
stream: yield expected Error class on zlib errors
2e0abed
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva@RafaelGSS
test: update WPT files for WebIDL tests
f25637b
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
8b1ff5a
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 12, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
c519e80
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
1aec6f6
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
21c61f5
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva

panva commented Dec 15, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Backport blocked until #50097 is also backported.

UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
23734d5
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@panva@UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
4cf155c
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@anonriganonriganonrig approved these changes
@ljharbljharbAwaiting requested review from ljharb

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@ljharb@mcollina@anonrig@targos