test: favor arrow functions in callbacks

UjjwalUpadhyay123-bit · codebytere · commit 2ffbde396373 · 2019-01-28T21:54:52.000-08:00
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-https-agent-servername.js b/test/parallel/test-https-agent-servername.js
@@ -1,5 +1,6 @@
 'use strict';
 const common = require('../common');
+const assert = require('assert');
 
 if (!common.hasCrypto)
 common.skip('missing crypto');
@@ -14,7 +15,7 @@ const options = {
 };
 
 
-const server = https.Server(options, function(req, res) {
+const server = https.Server(options, (req, res) => {
 res.writeHead(200);
 res.end('hello world\n');
 });
@@ -27,11 +28,11 @@ server.listen(0, function() {
 rejectUnauthorized: true,
 servername: 'agent1',
 ca: options.ca
- }, function(res) {
+ }, (res) => {
 res.resume();
- console.log(res.statusCode);
+ assert.strictEqual(res.statusCode, 200);
 server.close();
- }).on('error', function(e) {
+ }).on('error', (e) => {
 console.log(e.message);
 process.exit(1);
 });

-Original file line number
+Diff line change
@@ @@ -1,5 +1,6 @@ @@
 'use strict';
 constcommon=require('../common');
 +constassert=require('assert');
 if(!common.hasCrypto)
 common.skip('missing crypto');
 };
 -constserver=https.Server(options,function(req,res){
 +constserver=https.Server(options,(req,res)=>{
 res.writeHead(200);
 res.end('hello world\n');
 });
 rejectUnauthorized: true,
 servername: 'agent1',
 ca: options.ca
 -},function(res){
 +},(res)=>{
 res.resume();
 -console.log(res.statusCode);
 +assert.strictEqual(res.statusCode,200);
 server.close();
 -}).on('error',function(e){
 +}).on('error',(e)=>{
 console.log(e.message);
 process.exit(1);
 });