Uh oh!
There was an error while loading. Please reload this page.
test: converted normal functions to arrow functions in unit test file - #24425
Closed
UjjwalUpadhyay123-bit wants to merge 3 commits into
Closed
test: converted normal functions to arrow functions in unit test file#24425UjjwalUpadhyay123-bit wants to merge 3 commits into
UjjwalUpadhyay123-bit wants to merge 3 commits into
Conversation
UjjwalUpadhyay123-bit
commented
Nov 17, 2018
ContributorAuthor
@ryzokuken - Please merge this PR related to converting normal functions to arrow functions in test/parallel/test-https-agent-servername.js - assignment #JSARROW15 |
gireeshpunathil
approved these changes
Nov 18, 2018
gireeshpunathil
commented
Nov 18, 2018
Member
@UjjwalUpadhyay - the commit message is not conforming to the guidelines, it should start with the subsystem name, in this case test. guidelines: It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks! error details in the CI log |
gireeshpunathil
approved these changes
Nov 18, 2018
trivikr
approved these changes
Nov 18, 2018
ryzokuken
approved these changes
Nov 18, 2018
ryzokuken
left a comment
Contributor
There was a problem hiding this comment.
@gireeshpunathil perhaps the commit message could be taken care of by the committer?
cjihrig
approved these changes
Nov 18, 2018
Trott
commented
Nov 18, 2018
Member
refack
commented
Nov 18, 2018
Contributor
Trott
commented
Nov 18, 2018
Member
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18729/ |
jasnell
approved these changes
Nov 19, 2018
gireeshpunathil
commented
Nov 19, 2018
Member
fast-track? please 👍 |
sagirk
approved these changes
Nov 19, 2018
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
PR-URL: nodejs#24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Nov 19, 2018
Member
Landed in 6363f21. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos pushed a commit
that referenced
this pull request
Nov 19, 2018
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 7, 2018
codebytere pushed a commit
that referenced
this pull request
Jan 13, 2019
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jan 29, 2019
PR-URL: #24425 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes