test: add cb error test for fs.close()

teorossi82 · targos · commit 3e3990902253 · 2019-11-10T14:50:11.000+01:00
Provides some missing test coverage. PR-URL: #29970 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-fs-close-errors.js b/test/parallel/test-fs-close-errors.js
@@ -17,3 +17,19 @@ const fs = require('fs');
 assert.throws(() => fs.close(input), errObj);
 assert.throws(() => fs.closeSync(input), errObj);
 });
+
+{
+ // Test error when cb is not a function
+ const fd = fs.openSync(__filename, 'r');
+
+ const errObj = {
+ code: 'ERR_INVALID_CALLBACK',
+ name: 'TypeError'
+ };
+
+ ['', false, null, {}, []].forEach((input) => {
+ assert.throws(() => fs.close(fd, input), errObj);
+ });
+
+ fs.closeSync(fd);
+}

-Original file line number
+Diff line change
 assert.throws(()=>fs.close(input),errObj);
 assert.throws(()=>fs.closeSync(input),errObj);
 });
++
 +{
 +// Test error when cb is not a function
 +constfd=fs.openSync(__filename,'r');
++
 +consterrObj={
 +code: 'ERR_INVALID_CALLBACK',
 +name: 'TypeError'
 +};
++
 +['',false,null,{},[]].forEach((input)=>{
 +assert.throws(()=>fs.close(fd,input),errObj);
 +});
++
 +fs.closeSync(fd);
 +}