Skip to content

test: add cb error test for fs.close method - #29970

Closed
teorossi82 wants to merge 3 commits into
nodejs:masterfrom
teorossi82:test-fs-close-cb-error
Closed

test: add cb error test for fs.close method#29970
teorossi82 wants to merge 3 commits into
nodejs:masterfrom
teorossi82:test-fs-close-cb-error

Conversation

@teorossi82

@teorossi82teorossi82 commented Oct 14, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Added test on fs.close method when callback is not a function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 14, 2019
@Fishrock123

Fishrock123 commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3992/

Fishrock123
Fishrock123 suggested changes Oct 14, 2019
View reviewed changes

@Fishrock123Fishrock123 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call fs.closeSync(fd) at the bottom of the test file.

(Or, better, put the test case in a callback, and then have the close be async too. If you do that, make sure you wrap the callbacks in common.mustCall().)

@Trott

Trott commented Oct 14, 2019

Copy link
Copy Markdown
Member

I wouldn't mind these new lines being block-scoped (add a { before the new block and a } after) so that fd doesn't leak out to other test cases added later.

@Trott

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member

Out of curiosity, what caused you to write this test? Were you reviewing coverage.nodejs.org and this test is intended to add coverage where we currently don't have coverage? Or is there a different reason you're doing this?

Trott
Trott approved these changes Oct 15, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a closeSync() added after the forEach stuff.

Trott
Trott reviewed Oct 15, 2019
View reviewed changes
Comment threadtest/parallel/test-fs-close-errors.js Outdated
const errObj = {
code: 'ERR_INVALID_CALLBACK',
name: 'TypeError'
};

@TrottTrottOct 15, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit-pick: You can move the errObj definition outside of the forEach() to below the fd definition. This way, it's only being defined once.

@teorossi82

teorossi82 commented Oct 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Out of curiosity, what caused you to write this test?

I have just took a look to coverage.nodejs.org page and found that this piece of code was not covered. I would like to help you reach 100% coverage :-)

@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26041/

@Trott

Trott commented Oct 15, 2019

Copy link
Copy Markdown
Member

CI (probably) won't pass until #29979 lands first. If a Collaborator wants to be the second fast-track approval on that PR, thumbs up at #29979 (comment).

@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26046/

@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26048/

@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26056/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2019
@teorossi82

teorossi82 commented Oct 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@Trott I have to do something to unlock problems with CI or it's not related to my changes and I just have to wait?

@Trott

Trott commented Oct 16, 2019

Copy link
Copy Markdown
Member

@Trott I have to do something to unlock problems with CI or it's not related to my changes and I just have to wait?

CI is passing. The GitHub interface doesn't always update. Not sure if that's a problem with our bot or with GitHub or something else. But this is all good to go. You don't need to do anything but wait for someone to land it. Which I'm going to do right now!

Trott pushed a commit that referenced this pull request Oct 16, 2019
@teorossi82@Trott
test: add cb error test for fs.close()
e22efba
Provides some missing test coverage.
PR-URL: #29970
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Oct 16, 2019

Copy link
Copy Markdown
Member

Landed in e22efba.

Thanks for the contribution! 🎉

@TrottTrott closed this Oct 16, 2019
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
@teorossi82@MylesBorins
test: add cb error test for fs.close()
b1b8663
Provides some missing test coverage.
PR-URL: #29970
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 23, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@teorossi82@targos
test: add cb error test for fs.close()
5e436f8
Provides some missing test coverage.
PR-URL: #29970
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@teorossi82@targos
test: add cb error test for fs.close()
3e39909
Provides some missing test coverage.
PR-URL: #29970
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@jasnelljasnelljasnell approved these changes
+1 more reviewer
@Fishrock123Fishrock123Fishrock123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@teorossi82@Fishrock123@Trott@nodejs-github-bot@jasnell