Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 4674a10

Browse files
hallss93cursoragent
authored andcommitted
quic: convert incoming :status header to number
Signed-off-by: Hallison Melo <hallss93@hotmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> PR-URL: #63589Fixes: #63557 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
1 parent e52e573 commit 4674a10

22 files changed

Lines changed: 114 additions & 44 deletions

β€Ždoc/api/quic.mdβ€Ž

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3980,8 +3980,9 @@ A few things to note:
39803980
the request is `HEADERS` followed by `END_STREAM`.
39813981
* The `onheaders` callback receives the response pseudo-headers and
39823982
regular headers in a single object with lowercase string keys.
3983-
After the callback returns, the same object is also accessible
3984-
via [`stream.headers`][].
3983+
For incoming headers, the `:status` pseudo-header is converted to
3984+
a `number`, matching HTTP/2 behavior. After the callback returns,
3985+
the same object is also accessible via [`stream.headers`][].
39853986
* Reading `for await (const chunks of stream)` consumes the response
39863987
body. Each iteration yields a `Uint8Array[]` batch of chunks.
39873988
* HTTP semantic helpers (URL parsing, method/status validation,

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
12851285
assert(pairs.length%2===0);
12861286
constblock={__proto__: null};
12871287
for(letn=0;n+1<pairs.length;n+=2){
1288-
if(block[pairs[n]]!==undefined){
1289-
if(ArrayIsArray(block[pairs[n]])){
1290-
ArrayPrototypePush(block[pairs[n]],pairs[n+1]);
1288+
constname=pairs[n];
1289+
letvalue=pairs[n+1];
1290+
// Match HTTP/2 behavior: incoming :status is exposed as a number.
1291+
if(name===':status')
1292+
value|=0;
1293+
if(block[name]!==undefined){
1294+
if(ArrayIsArray(block[name])){
1295+
ArrayPrototypePush(block[name],value);
12911296
}else{
1292-
block[pairs[n]]=[block[pairs[n]],pairs[n+1]];
1297+
block[name]=[block[name],value];
12931298
}
12941299
}else{
1295-
block[pairs[n]]=pairs[n+1];
1300+
block[name]=value;
12961301
}
12971302
}
12981303
returnblock;

β€Žtest/parallel/test-quic-h3-callback-errors.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall(function(headers){
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
ontrailers: mustCall(function(){
157157
thrownewError('ontrailers sync error');
@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
265265
':authority': 'localhost',
266266
},
267267
onheaders: mustCall(function(headers){
268-
assert.strictEqual(headers[':status'],'200');
268+
assert.strictEqual(headers[':status'],200);
269269
}),
270270
});
271271

β€Žtest/parallel/test-quic-h3-close-behavior.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
6262
':authority': 'localhost',
6363
},
6464
onheaders: mustCall((headers)=>{
65-
assert.strictEqual(headers[':status'],'200');
65+
assert.strictEqual(headers[':status'],200);
6666
}),
6767
});
6868

@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
7474
':authority': 'localhost',
7575
},
7676
onheaders: mustCall((headers)=>{
77-
assert.strictEqual(headers[':status'],'200');
77+
assert.strictEqual(headers[':status'],200);
7878
}),
7979
});
8080

β€Žtest/parallel/test-quic-h3-concurrent-requests.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
7272
':authority': 'localhost',
7373
},
7474
onheaders: mustCall((headers)=>{
75-
assert.strictEqual(headers[':status'],'200');
75+
assert.strictEqual(headers[':status'],200);
7676
headersReceived.resolve();
7777
}),
7878
});

β€Žtest/parallel/test-quic-h3-datagram.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
8787
':authority': 'localhost',
8888
},
8989
onheaders: mustCall(function(headers){
90-
assert.strictEqual(headers[':status'],'200');
90+
assert.strictEqual(headers[':status'],200);
9191
}),
9292
});
9393

@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
151151
':authority': 'localhost',
152152
},
153153
onheaders: mustCall((headers)=>{
154-
assert.strictEqual(headers[':status'],'200');
154+
assert.strictEqual(headers[':status'],200);
155155
}),
156156
});
157157

β€Žtest/parallel/test-quic-h3-error-codes.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
5555
':authority': 'localhost',
5656
},
5757
onheaders: mustCall(function(headers){
58-
assert.strictEqual(headers[':status'],'200');
58+
assert.strictEqual(headers[':status'],200);
5959
}),
6060
});
6161

@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
106106
':authority': 'localhost',
107107
},
108108
onheaders: mustCall(function(headers){
109-
assert.strictEqual(headers[':status'],'200');
109+
assert.strictEqual(headers[':status'],200);
110110
}),
111111
});
112112

β€Žtest/parallel/test-quic-h3-goaway.mjsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
7878
awaitclientSession.opened;
7979

8080
constonClientHeaders=mustCall(function(headers){
81-
assert.strictEqual(headers[':status'],'200');
81+
assert.strictEqual(headers[':status'],200);
8282
if(++clientHeaderCount===2){
8383
bothHeadersReceived.resolve();
8484
}

β€Žtest/parallel/test-quic-h3-header-validation.mjsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
9191
},
9292
onheaders: mustCall(function(headers){
9393
// Client should also receive lowercased response header names.
94-
assert.strictEqual(headers[':status'],'200');
94+
assert.strictEqual(headers[':status'],200);
9595
assert.strictEqual(headers['content-type'],'text/html');
9696
assert.strictEqual(headers['x-response-header'],'ResponseValue');
9797

@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
148148
':authority': 'localhost',
149149
},
150150
onheaders: mustCall((headers)=>{
151-
assert.strictEqual(headers[':status'],'204');
151+
assert.strictEqual(headers[':status'],204);
152152
}),
153153
});
154154

β€Žtest/parallel/test-quic-h3-informational-headers.mjsβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
3434
assert.ok(msg.stream,'stream.info should include stream');
3535
assert.ok(msg.session,'stream.info should include session');
3636
assert.ok(msg.headers,'stream.info should include headers');
37-
assert.strictEqual(msg.headers[':status'],'103');
37+
assert.strictEqual(msg.headers[':status'],103);
3838
}));
3939

4040
// quic.stream.headers also fires for the final response headers.
@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
8989
':authority': 'localhost',
9090
},
9191
oninfo: mustCall(function(headers){
92-
assert.strictEqual(headers[':status'],'103');
92+
assert.strictEqual(headers[':status'],103);
9393
assert.strictEqual(headers.link,'</style.css>; rel=preload; as=style');
9494
clientInfoReceived.resolve();
9595
}),
9696
onheaders: mustCall(function(headers){
97-
assert.strictEqual(headers[':status'],'200');
97+
assert.strictEqual(headers[':status'],200);
9898
assert.strictEqual(headers['content-type'],'text/plain');
9999
clientHeadersReceived.resolve();
100100
}),
@@ -107,7 +107,7 @@ const body = await bytes(stream);
107107
assert.strictEqual(decoder.decode(body),responseBody);
108108

109109
// stream.headers should return the final (initial) headers, not 1xx.
110-
assert.strictEqual(stream.headers[':status'],'200');
110+
assert.strictEqual(stream.headers[':status'],200);
111111

112112
awaitPromise.all([stream.closed,serverDone.promise]);
113113
awaitclientSession.close();

0 commit comments

Comments
Β (0)