quic: convert incoming :status header to number - #63589

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hallss93:quic-h3-status-number
Aug 9, 2026
Merged

quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
hallss93:quic-h3-status-number

Conversation

@hallss93

@hallss93hallss93 commented May 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #63557

Summary

When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a
string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it
awkward to port HTTP/2 code to HTTP/3.

Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value
pairs. This applies to initial response headers, informational (1xx)
headers (oninfo), and stream.headers.

Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().

Test plan

  • Update existing QUIC H3 tests to expect numeric :status on receive

  • Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404

  • Run (with QUIC enabled):

    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs

@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels May 26, 2026
@hallss93hallss93 mentioned this pull request May 26, 2026
Closed
@pimterry

pimterry commented May 28, 2026

Copy link
Copy Markdown
Member

@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.

@codecov

codecovBot commented May 28, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hallss93
hallss93force-pushed the quic-h3-status-number branch from f442353 to 25644d0CompareJune 5, 2026 17:30
@hallss93

hallss93 commented Jun 5, 2026

Copy link
Copy Markdown
ContributorAuthor

@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.

fixed

@pimterrypimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 8, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586

@trivikr

trivikr commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@hallss93 Can you please rebase onto main and remove the merge commit?

Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase

bjohansebas
bjohansebas approved these changes Jun 21, 2026
View reviewed changes

@bjohansebasbjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjohansebasbjohansebas added commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed the quic-h3-status-number branch from 04c9e28 to 861d2a4CompareAugust 8, 2026 18:07
@jasnell

jasnell commented Aug 8, 2026

Copy link
Copy Markdown
Member

Rebased to address the merge conflicts

@jasnell

jasnell commented Aug 8, 2026

Copy link
Copy Markdown
Member

@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed the quic-h3-status-number branch from 861d2a4 to b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75664/

Qard
Qard approved these changes Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot merged commit cbe18d8 into nodejs:mainAug 9, 2026
68 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Landed in cbe18d8

aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes
+3 more reviewers
@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2

9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
quic: convert incoming :status header to number - #63589
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Aug 9, 2026
Merged
quic: convert incoming :status header to number#63589
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
hallss93:quic-h3-status-number
Conversation
@hallss93
@hallss93hallss93
commented
May 26, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC, headers[':status'] was exposed as a

string. HTTP/2 converts the incoming :status pseudo-header to a number in
toHeaderObject() (lib/internal/http2/util.js). This mismatch makes it

awkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting :status to a number in
parseHeaderPairs() when building the header object from C++ name/value

pairs. This applies to initial response headers, informational (1xx)

headers (oninfo), and stream.headers.
Outgoing headers are unchanged: callers may still pass ':status': '200' or
':status': 200 when calling sendHeaders() / sendInformationalHeaders().
Test plan
  •  Update existing QUIC H3 tests to expect numeric :status on receive
  •  Add test/parallel/test-quic-h3-status-code-type.mjs covering 200, 204, and 404
  •  Run (with QUIC enabled):
    node --experimental-quic --experimental-stream-iter --no-warnings \
test/parallel/test-quic-h3-status-code-type.mjs \
test/parallel/test-quic-h3-header-validation.mjs \
test/parallel/test-quic-h3-informational-headers.mjs \
test/parallel/test-quic-h3-request-response.mjs
@nodejs-github-bot
nodejs-github-bot
commented
May 26, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC transport implementation.
labels
May 26, 2026
@hallss93hallss93
mentioned this pull request
May 26, 2026

Closed

@pimterry
pimterry
commented
May 28, 2026

Copy link


Copy Markdown

Member
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
@codecov
codecovBot
commented
May 28, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.32%. Comparing base (98fd6cb) to head (b9b662f).
⚠️ Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #63589 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01% 
==========================================
Files 759 759 Lines 248320 248330 +10 Branches 46868 46862 -6 ==========================================
- Hits 224296 224292 -4 
Misses 15466 15466 - Partials 8558 8572 +14 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@hallss93
hallss93force-pushed
the
quic-h3-status-number
branch
from
f442353 to
25644d0CompareJune 5, 2026 17:30
@hallss93
hallss93
commented
Jun 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with git commit --amend -s and then force push.
fixed
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterrypimterry
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Jun 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jun 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63589
✔ Done loading data for nodejs/node/pull/63589
----------------------------------- PR info ------------------------------------
Title quic: convert incoming :status header to number (#63589)
Author Hallison Pereira Melo <hallss93@hotmail.com> (@hallss93, first-time contributor)
Branch hallss93:quic-h3-status-number -> nodejs:main
Labels needs-ci, quic, commit-queue-squash
Commits 2
- quic: convert incoming :status header to number
- Merge branch 'nodejs:main' into quic-h3-status-number
Committers 2
- Hallison Melo <hallss93@hotmail.com>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63589
Fixes: https://github.com/nodejs/node/issues/63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 26 May 2026 18:45:32 GMT
✔ Approvals: 2
✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63589#pullrequestreview-4378129270
✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/63589#pullrequestreview-4449032505
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-06-08T13:56:50Z: https://ci.nodejs.org/job/node-test-pull-request/73976/
- Querying data for job/node-test-pull-request/73976/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 63589
From https://github.com/nodejs/node
* branch refs/pull/63589/merge -> FETCH_HEAD
✔ Fetched commits as 45c7071b4a0d..04c9e28facb5
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
error: commit 04c9e28facb599da6a23142450bbf8c85e32bcd0 is a merge but no -m option was given.
fatal: cherry-pick failed
[main dad2bd067b] quic: convert incoming :status header to number
Author: Hallison Melo <hallss93@hotmail.com>
Date: Tue May 26 15:40:36 2026 -0300
22 files changed, 117 insertions(+), 44 deletions(-)
create mode 100644 test/parallel/test-quic-h3-status-code-type.mjs
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/27160616586
@trivikr
trivikr
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
@hallss93 Can you please rebase onto main and remove the merge commit?
Instructions: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
bjohansebas
bjohansebas
approved these changes
Jun 21, 2026
View reviewed changes
@bjohansebasbjohansebas
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@bjohansebasbjohansebas
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Jun 21, 2026
@jasnell

This comment was marked as resolved.

Sign in to view
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
04c9e28 to
861d2a4CompareAugust 8, 2026 18:07
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Rebased to address the merge conflicts
@jasnell
jasnell
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
@Qard@pimterry ... can I ask for a stamp again on this, I can't stamp it any longer since I pushed the rebase
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@hallss93@cursoragent@jasnell
quic: convert incoming :status header to number
b9b662f
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@jasnell
jasnellforce-pushed
the
quic-h3-status-number
branch
from
861d2a4 to
b9b662fCompareAugust 8, 2026 18:27
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75664/
Qard
Qard
approved these changes
Aug 8, 2026
View reviewed changes
@bjohansebasbjohansebas
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 9, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cbe18d8
into
nodejs:mainAug 9, 2026

68 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
Landed in cbe18d8
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
63b70df
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
4674a10
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@hallss93@cursoragent@aduh95
quic: convert incoming :status header to number
88bee43
Signed-off-by: Hallison Melo <hallss93@hotmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR-URL: #63589Fixes: #63557
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@QardQardQard approved these changes
@pimterrypimterrypimterry approved these changes

+3 more reviewers

@efekrsklefekrsklefekrskl approved these changes
@metcoder95metcoder95metcoder95 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.quicIssues and PRs related to the QUIC transport implementation.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

quic: http/3 headers behave differently than http/2


9 participants

@hallss93@nodejs-github-bot@pimterry@trivikr@jasnell@Qard@efekrskl@metcoder95@bjohansebas