tools: fix bug in prefer-primordials ESLint rule

Refs: #40622
PR-URL: #40628
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: aduh95

test/parallel/test-eslint-prefer-primordials.js

@@ -81,6 +81,23 @@ new RuleTester({
 code: 'const { Map } = primordials; new Map()',
 options: [{name: 'Map',into: 'Safe'}],
 },
+{
+code: `
+ const { Function } = primordials;
+ const rename = Function;
+ const obj = { rename };
+ `,
+options: [{name: 'Function'}],
+},
+{
+code: `
+ const { Function } = primordials;
+ let rename;
+ rename = Function;
+ const obj = { rename };
+ `,
+options: [{name: 'Function'}],
+},
 ],
 invalid: [
 {
@@ -158,6 +175,16 @@ new RuleTester({
 options: [{name: 'Reflect'}],
 errors: [{message: /const{ReflectOwnKeys}=primordials/}]
 },
+{
+code: `
+ const { Reflect } = primordials;
+ module.exports = function() {
+ const { ownKeys } = Reflect;
+ }
+ `,
+options: [{name: 'Reflect'}],
+errors: [{message: /const{ReflectOwnKeys}=primordials/}]
+},
 {
 code: 'new Map()',
 options: [{name: 'Map',into: 'Safe'}],
@@ -171,5 +198,36 @@ new RuleTester({
 options: [{name: 'Function'}],
 errors: [{message: /const{FunctionPrototype}=primordials/}]
 },
+{
+code: `
+ const obj = { Function };
+ `,
+options: [{name: 'Function'}],
+errors: [{message: /const{Function}=primordials/}]
+},
+{
+code: `
+ const rename = Function;
+ `,
+options: [{name: 'Function'}],
+errors: [{message: /const{Function}=primordials/}]
+},
+{
+code: `
+ const rename = Function;
+ const obj = { rename };
+ `,
+options: [{name: 'Function'}],
+errors: [{message: /const{Function}=primordials/}]
+},
+{
+code: `
+ let rename;
+ rename = Function;
+ const obj = { rename };
+ `,
+options: [{name: 'Function'}],
+errors: [{message: /const{Function}=primordials/}]
+},
 ]
 });

tools/eslint-rules/prefer-primordials.js

@@ -54,7 +54,7 @@ function getDestructuringAssignmentParent(scope, node) {
 ){
 returnnull;
 }
-returndeclaration.defs[0].node.init.name;
+returndeclaration.defs[0].node.init;
 }
 
 constidentifierSelector=
@@ -94,17 +94,20 @@ module.exports = {
 return;
 }
 constname=node.name;
-constparentName=getDestructuringAssignmentParent(
+constparent=getDestructuringAssignmentParent(
 context.getScope(),
 node
 );
+constparentName=parent?.name;
 if(!isTarget(nameMap,name)&&!isTarget(nameMap,parentName)){
 return;
 }
 
 constdefs=globalScope.set.get(name)?.defs;
 if(parentName&&isTarget(nameMap,parentName)){
-if(!defs||defs[0].name.name!=='primordials'){
+if(defs?.[0].name.name!=='primordials'&&
+!reported.has(parent.range[0])&&
+parent.parent?.id?.type!=='Identifier'){
 reported.add(node.range[0]);
 constinto=renameMap.get(name);
 context.report({
@@ -147,7 +150,20 @@ module.exports = {
 }
 });
 }
-}
+},
+VariableDeclarator(node){
+constname=node.init?.name;
+if(name!==undefined&&isTarget(nameMap,name)&&
+node.id.type==='Identifier'&&
+!globalScope.set.get(name)?.defs.length){
+reported.add(node.init.range[0]);
+context.report({
+ node,
+messageId: 'error',
+data: { name },
+});
+}
+},
 };
 }
 };