Skip to content

stream: rename unknown primordial - #40622

Closed
VoltrexKeyva wants to merge 2 commits into
nodejs:masterfrom
VoltrexKeyva:fix-unknown-primordial
Closed

stream: rename unknown primordial#40622
VoltrexKeyva wants to merge 2 commits into
nodejs:masterfrom
VoltrexKeyva:fix-unknown-primordial

Conversation

@VoltrexKeyva

@VoltrexKeyvaVoltrexKeyva commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

The primordials does not expose a primordial called DataViewCtor, leading up to a non-existent constructor.

Fixes: #40612

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 27, 2021
@VoltrexKeyvaVoltrexKeyva changed the title webstreams: rename unknown primordialstream: rename unknown primordialOct 27, 2021
@VoltrexKeyvaVoltrexKeyva added stream Issues and PRs related to the stream subsystem. web streams needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Oct 27, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex

mscdex commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

We should probably add a test for this.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@VoltrexKeyva

VoltrexKeyva commented Oct 27, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This is strange, our node-core/prefer-primordials rule seems to be preferring the usage of DataViewCtor instead of DataView even though primordials does not expose a primordial called DataViewCtor...

@targos

targos commented Oct 27, 2021

Copy link
Copy Markdown
Member

This is strange, our node-core/prefer-primordials rule seems to be preferring the usage of DataViewCtor instead of DataView even though primordials does not expose a primordial called DataViewCtor...

It's probably a bug in the rule.

@aduh95aduh95 mentioned this pull request Oct 27, 2021
Merged
@aduh95

aduh95 commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

This is strange, our node-core/prefer-primordials rule seems to be preferring the usage of DataViewCtor instead of DataView even though primordials does not expose a primordial called DataViewCtor...

It's probably a bug in the rule.

It is, fix in #40628.

@github-actionsgithub-actionsBot mentioned this pull request Oct 28, 2021
Open
30 tasks
@MesteeryMesteery removed the needs-ci PRs that need a full CI run. label Oct 28, 2021
@github-actionsgithub-actionsBot mentioned this pull request Oct 29, 2021
Open
33 tasks
aduh95 added a commit to nodejs/node-auto-test that referenced this pull request Oct 29, 2021
@aduh95
doc: update README fot testing gh squashung (#34)
aea63a1
commit 958a05db7e7d9ec62e3aea119aad10c7cfd39ba6
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Wed Oct 27 16:17:05 2021 +0200
tools: fix bug in `prefer-primordials` ESLint rule
Refs: nodejs/node#40622
PR-URL: nodejs/node#40628
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 30, 2021
Open
Open
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Jan 20, 2022
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42039/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 20, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 20, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5753eb1...de9dc41

nodejs-github-bot pushed a commit that referenced this pull request Jan 20, 2022
@VoltrexKeyva@nodejs-github-bot
stream: rename unknown primordial
c4a6f9a
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 20, 2022
@VoltrexKeyva@nodejs-github-bot
test: add DataView test entry for whatwg
de9dc41
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@VoltrexKeyva
VoltrexKeyva deleted the fix-unknown-primordial branch January 20, 2022 12:02
@github-actionsgithub-actionsBot mentioned this pull request Jan 21, 2022
Open
19 tasks
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@VoltrexKeyva@BethGriggs
stream: rename unknown primordial
5027e94
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@VoltrexKeyva@BethGriggs
test: add DataView test entry for whatwg
6de8e51
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@VoltrexKeyva@danielleadams
stream: rename unknown primordial
9e19749
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@VoltrexKeyva@danielleadams
test: add DataView test entry for whatwg
26e3f4c
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@VoltrexKeyva@danielleadams
stream: rename unknown primordial
16d8424
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@VoltrexKeyva@danielleadams
test: add DataView test entry for whatwg
c492f12
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@VoltrexKeyva@danielleadams
stream: rename unknown primordial
ca60d29
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@VoltrexKeyva@danielleadams
test: add DataView test entry for whatwg
512da52
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@VoltrexKeyva@danielleadams
stream: rename unknown primordial
4f4fec4
The primordials does not expose a primordial called `DataViewCtor`,
leading up to a non-existent constructor.
Fixes: #40612
PR-URL: #40622
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@VoltrexKeyva@danielleadams
test: add DataView test entry for whatwg
122eb51
The WHATWG `ReadableStream` test needs a new test entry for reading a
`DataView`.
PR-URL: #40622Fixes: #40612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@tniessentniessentniessen approved these changes
@JungMinuJungMinuJungMinu approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ReadableStreamBYOBReader read() throws when given DataView

11 participants

@VoltrexKeyva@nodejs-github-bot@mscdex@targos@aduh95@Ayase-252@jasnell@tniessen@JungMinu@danielleadams@Mesteery