crypto: rename check to createJob

danbev · targos · commit 644c41638912 · 2020-11-03T17:54:20.000+01:00
This commit renames the check function to createJob which seems to be more descriptive of what this function does. PR-URL: #35858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/internal/crypto/keygen.js b/lib/internal/crypto/keygen.js
@@ -71,7 +71,7 @@ function generateKeyPair(type, options, callback) {
 if (typeof callback !== 'function')
 throw new ERR_INVALID_CALLBACK(callback);
 
- const job = check(kCryptoJobAsync, type, options);
+ const job = createJob(kCryptoJobAsync, type, options);
 
 job.ondone = (error, result) => {
 if (error) return FunctionPrototypeCall(callback, job, error);
@@ -91,7 +91,7 @@ ObjectDefineProperty(generateKeyPair, customPromisifyArgs, {
 });
 
 function generateKeyPairSync(type, options) {
- return handleError(check(kCryptoJobSync, type, options).run());
+ return handleError(createJob(kCryptoJobSync, type, options).run());
 }
 
 function handleError(ret) {
@@ -152,7 +152,7 @@ function parseKeyEncoding(keyType, options = {}) {
 ];
 }
 
-function check(mode, type, options) {
+function createJob(mode, type, options) {
 validateString(type, 'type');
 
 const encoding = parseKeyEncoding(type, options);

-Original file line number
+Diff line change
 if(typeofcallback!=='function')
 thrownewERR_INVALID_CALLBACK(callback);
 -constjob=check(kCryptoJobAsync,type,options);
 +constjob=createJob(kCryptoJobAsync,type,options);
 job.ondone=(error,result)=>{
 if(error)returnFunctionPrototypeCall(callback,job,error);
 });
 functiongenerateKeyPairSync(type,options){
 -returnhandleError(check(kCryptoJobSync,type,options).run());
 +returnhandleError(createJob(kCryptoJobSync,type,options).run());
+}
 functionhandleError(ret){
 ];
+}
 -functioncheck(mode,type,options){
 +functioncreateJob(mode,type,options){
 validateString(type,'type');
 constencoding=parseKeyEncoding(type,options);