Uh oh!
There was an error while loading. Please reload this page.
crypto: rename check to createJob - #35858
Merged
Merged
Conversation
nodejs-github-bot
commented
Oct 29, 2020
Collaborator
Review requested:
|
nodejs-github-bot
commented
Oct 29, 2020
Collaborator
Trott
approved these changes
Oct 29, 2020
targos
approved these changes
Oct 29, 2020
benjamingr
approved these changes
Oct 29, 2020
danbev
commented
Oct 30, 2020
ContributorAuthor
Re-run of failing node-test-commit-plinux ✔️ |
This commit renames the check function to createJob which seems to be more descriptive of what this function does. PR-URL: nodejs#35858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trottforce-pushed
the
webcrypto-keygen-createjob
branch
from
October 31, 2020 11:45
a152fa6 to
65c9d67CompareTrott
commented
Oct 31, 2020
Member
Landed in 65c9d67 |
targos pushed a commit
that referenced
this pull request
Nov 3, 2020
This commit renames the check function to createJob which seems to be more descriptive of what this function does. PR-URL: #35858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames the check function to createJob which seems to be
more descriptive of what this function does.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes