perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN

Lxxyx · targos · commit 726ef40fcb82 · 2021-06-11T09:29:57.000+02:00
Fixes: #36936 PR-URL: #36937 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/histogram.js b/lib/internal/histogram.js
@@ -5,7 +5,7 @@ const {
 } = require('internal/util');
 
 const { format } = require('util');
-const { SafeMap, Symbol } = primordials;
+const { NumberIsNaN, SafeMap, Symbol } = primordials;
 
 const {
 ERR_INVALID_ARG_TYPE,
@@ -61,7 +61,7 @@ class Histogram {
 if (typeof percentile !== 'number')
 throw new ERR_INVALID_ARG_TYPE('percentile', 'number', percentile);
 
- if (percentile <= 0 || percentile > 100)
+ if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
 throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile);
 
 return this[kHandle]?.percentile(percentile);
diff --git a/test/sequential/test-performance-eventloopdelay.js b/test/sequential/test-performance-eventloopdelay.js
@@ -86,7 +86,7 @@ const { sleep } = require('internal/util');
 }
 );
 });
- [-1, 0, 101].forEach((i) => {
+ [-1, 0, 101, NaN].forEach((i) => {
 assert.throws(
 () => histogram.percentile(i),
 {

-Original file line number
+Diff line change
 }=require('internal/util');
 const{ format }=require('util');
 -const{ SafeMap, Symbol }=primordials;
 +const{NumberIsNaN,SafeMap, Symbol }=primordials;
 const{
 ERR_INVALID_ARG_TYPE,
 if(typeofpercentile!=='number')
 thrownewERR_INVALID_ARG_TYPE('percentile','number',percentile);
 -if(percentile<=0||percentile>100)
 +if(NumberIsNaN(percentile)||percentile<=0||percentile>100)
 thrownewERR_INVALID_ARG_VALUE.RangeError('percentile',percentile);
 returnthis[kHandle]?.percentile(percentile);
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ const { sleep } = require('internal/util');`
`86`	`86`	`}`
`87`	`87`	`);`
`88`	`88`	`});`
`89`		`-[-1,0,101].forEach((i)=>{`
	`89`	`+[-1,0,101,NaN].forEach((i)=>{`
`90`	`90`	`assert.throws(`
`91`	`91`	`()=>histogram.percentile(i),`
`92`	`92`	`{`