Skip to content

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN - #36937

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-perf_hooks-histogram-error
Closed

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN#36937
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-perf_hooks-histogram-error

Conversation

@Lxxyx

@LxxyxLxxyx commented Jan 15, 2021

Copy link
Copy Markdown
Member

Fixes: #36936

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35561/

@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35599/

@jasnell

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Landed in 59af4e6

@jasnelljasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@Lxxyx@jasnell
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
59af4e6
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Lxxyx
Lxxyx deleted the fix-perf_hooks-histogram-error branch January 18, 2021 21:43
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Lxxyx@ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
327a2b7
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@Lxxyx@ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
3f75a60
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 25, 2021
@Lxxyx@targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
579d199
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@Lxxyx@targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
bd298f7
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@Lxxyx@targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
38178b8
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@Lxxyx@targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
726ef40
… is NaN
Fixes: #36936
PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf_hooks: histogram.percentile throw Assertion `(percentile) > (0)' failed when param is NaN

6 participants

@Lxxyx@nodejs-github-bot@jasnell@cjihrig@aduh95@RaisinTen