module: use v8 synthetic modules

PR-URL: #29846
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

Author: guybedford

lib/internal/bootstrap/loaders.js

@@ -150,8 +150,7 @@ function NativeModule(id) {
 this.filename=`${id}.js`;
 this.id=id;
 this.exports={};
-this.reflect=undefined;
-this.esmFacade=undefined;
+this.module=undefined;
 this.exportKeys=undefined;
 this.loaded=false;
 this.loading=false;
@@ -240,16 +239,18 @@ NativeModule.prototype.getURL = function() {
 };
 
 NativeModule.prototype.getESMFacade=function(){
-if(this.esmFacade)returnthis.esmFacade;
-constcreateDynamicModule=nativeModuleRequire(
-'internal/modules/esm/create_dynamic_module');
+if(this.module)returnthis.module;
+const{ ModuleWrap }=internalBinding('module_wrap');
 consturl=this.getURL();
-returnthis.esmFacade=createDynamicModule(
-[],[...this.exportKeys,'default'],url,(reflect)=>{
-this.reflect=reflect;
-this.syncExports();
-reflect.exports.default.set(this.exports);
-});
+constnativeModule=this;
+this.module=newModuleWrap(function(){
+nativeModule.syncExports();
+this.setExport('default',nativeModule.exports);
+},[...this.exportKeys,'default'],url);
+// Ensure immediate sync execution to capture exports now
+this.module.instantiate();
+this.module.evaluate(-1,false);
+returnthis.module;
 };
 
 // Provide named exports for all builtin libraries so that the libraries
@@ -258,13 +259,12 @@ NativeModule.prototype.getESMFacade = function() {
 // called so that APMs and other behavior are supported.
 NativeModule.prototype.syncExports=function(){
 constnames=this.exportKeys;
-if(this.reflect){
+if(this.module){
 for(leti=0;i<names.length;i++){
 constexportName=names[i];
 if(exportName==='default')continue;
-this.reflect.exports[exportName].set(
-getOwn(this.exports,exportName,this.exports)
-);
+this.module.setExport(exportName,
+getOwn(this.exports,exportName,this.exports));
 }
 }
 };

lib/internal/modules/cjs/loader.js

@@ -75,9 +75,7 @@ const experimentalExports = getOptionValue('--experimental-exports');
 
 module.exports=Module;
 
-letasyncESM;
-letModuleJob;
-letcreateDynamicModule;
+letasyncESM,ModuleJob,ModuleWrap,kInstantiated;
 
 const{
 CHAR_FORWARD_SLASH,
@@ -820,21 +818,18 @@ Module.prototype.load = function(filename) {
 constmodule=ESMLoader.moduleMap.get(url);
 // Create module entry at load time to snapshot exports correctly
 constexports=this.exports;
-if(module!==undefined){// Called from cjs translator
-if(module.reflect){
-module.reflect.onReady((reflect)=>{
-reflect.exports.default.set(exports);
-});
-}
+// Called from cjs translator
+if(module!==undefined&&module.module!==undefined){
+if(module.module.getStatus()>=kInstantiated)
+module.module.setExport('default',exports);
 }else{// preemptively cache
 ESMLoader.moduleMap.set(
 url,
-newModuleJob(ESMLoader,url,async()=>{
-returncreateDynamicModule(
-[],['default'],url,(reflect)=>{
-reflect.exports.default.set(exports);
-});
-})
+newModuleJob(ESMLoader,url,()=>
+newModuleWrap(function(){
+this.setExport('default',exports);
+},['default'],url)
+)
 );
 }
 }
@@ -1145,6 +1140,5 @@ Module.Module = Module;
 if(experimentalModules){
 asyncESM=require('internal/process/esm_loader');
 ModuleJob=require('internal/modules/esm/module_job');
-createDynamicModule=require(
-'internal/modules/esm/create_dynamic_module');
+({ ModuleWrap, kInstantiated }=internalBinding('module_wrap'));
 }

lib/internal/modules/esm/loader.js

@@ -117,12 +117,7 @@ class Loader {
 source,
 url=pathToFileURL(`${process.cwd()}/[eval${++this.evalIndex}]`).href
 ){
-constevalInstance=async(url)=>{
-return{
-module: newModuleWrap(source,url),
-reflect: undefined
-};
-};
+constevalInstance=(url)=>newModuleWrap(source,url);
 constjob=newModuleJob(this,url,evalInstance,false);
 this.moduleMap.set(url,job);
 const{ module, result }=awaitjob.run();
@@ -165,7 +160,7 @@ class Loader {
 returncreateDynamicModule([],exports,url,(reflect)=>{
 debug(`Loading dynamic ${url}`);
 execute(reflect.exports);
-});
+}).module;
 };
 }else{
 if(!translators.has(format))

lib/internal/modules/esm/module_job.js

@@ -30,19 +30,17 @@ class ModuleJob {
 // onto `this` by `link()` below once it has been resolved.
 this.modulePromise=moduleProvider.call(loader,url,isMain);
 this.module=undefined;
-this.reflect=undefined;
 
 // Wait for the ModuleWrap instance being linked with all dependencies.
 constlink=async()=>{
-({module: this.module,
-reflect: this.reflect}=awaitthis.modulePromise);
+this.module=awaitthis.modulePromise;
 assert(this.moduleinstanceofModuleWrap);
 
 constdependencyJobs=[];
 constpromises=this.module.link(async(specifier)=>{
 constjobPromise=this.loader.getModuleJob(specifier,url);
 dependencyJobs.push(jobPromise);
-return(await(awaitjobPromise).modulePromise).module;
+return(awaitjobPromise).modulePromise;
 });
 
 if(promises!==undefined)

lib/internal/modules/esm/translators.js

@@ -33,6 +33,8 @@ const {
 constreadFileAsync=promisify(fs.readFile);
 constJsonParse=JSON.parse;
 const{ maybeCacheSourceMap }=require('internal/source_map/source_map_cache');
+constmoduleWrap=internalBinding('module_wrap');
+const{ ModuleWrap }=moduleWrap;
 
 constdebug=debuglog('esm');
 
@@ -78,22 +80,18 @@ translators.set('module', async function moduleStrategy(url) {
 constsource=`${awaitgetSource(url)}`;
 maybeCacheSourceMap(url,source);
 debug(`Translating StandardModule ${url}`);
-const{ ModuleWrap, callbackMap }=internalBinding('module_wrap');
 constmodule=newModuleWrap(stripShebang(source),url);
-callbackMap.set(module,{
+moduleWrap.callbackMap.set(module,{
  initializeImportMeta,
  importModuleDynamically,
 });
-return{
- module,
-reflect: undefined,
-};
+returnmodule;
 });
 
 // Strategy for loading a node-style CommonJS module
 constisWindows=process.platform==='win32';
 constwinSepRegEx=/\//g;
-translators.set('commonjs',asyncfunctioncommonjsStrategy(url,isMain){
+translators.set('commonjs',functioncommonjsStrategy(url,isMain){
 debug(`Translating CJSModule ${url}`);
 constpathname=internalURLModule.fileURLToPath(newURL(url));
 constcached=this.cjsCache.get(url);
@@ -106,17 +104,17 @@ translators.set('commonjs', async function commonjsStrategy(url, isMain) {
 ];
 if(module&&module.loaded){
 constexports=module.exports;
-returncreateDynamicModule([],['default'],url,(reflect)=>{
-reflect.exports.default.set(exports);
-});
+returnnewModuleWrap(function(){
+this.setExport('default',exports);
+},['default'],url);
 }
-returncreateDynamicModule([],['default'],url,()=>{
+returnnewModuleWrap(function(){
 debug(`Loading CJSModule ${url}`);
 // We don't care about the return val of _load here because Module#load
 // will handle it for us by checking the loader registry and filling the
 // exports like above
 CJSModule._load(pathname,undefined,isMain);
-});
+},['default'],url);
 });
 
 // Strategy for loading a node builtin CommonJS module that isn't
@@ -146,9 +144,9 @@ translators.set('json', async function jsonStrategy(url) {
 module=CJSModule._cache[modulePath];
 if(module&&module.loaded){
 constexports=module.exports;
-returncreateDynamicModule([],['default'],url,(reflect)=>{
-reflect.exports.default.set(exports);
-});
+returnnewModuleWrap(function(){
+this.setExport('default',exports);
+},['default'],url);
 }
 }
 constcontent=`${awaitgetSource(url)}`;
@@ -159,9 +157,9 @@ translators.set('json', async function jsonStrategy(url) {
 module=CJSModule._cache[modulePath];
 if(module&&module.loaded){
 constexports=module.exports;
-returncreateDynamicModule(['default'],url,(reflect)=>{
-reflect.exports.default.set(exports);
-});
+returnnewModuleWrap(function(){
+this.setExport('default',exports);
+},['default'],url);
 }
 }
 try{
@@ -181,10 +179,10 @@ translators.set('json', async function jsonStrategy(url) {
 if(pathname){
 CJSModule._cache[modulePath]=module;
 }
-returncreateDynamicModule([],['default'],url,(reflect)=>{
+returnnewModuleWrap(function(){
 debug(`Parsing JSONModule ${url}`);
-reflect.exports.default.set(module.exports);
-});
+this.setExport('default',module.exports);
+},['default'],url);
 });
 
 // Strategy for loading a wasm module
@@ -207,5 +205,5 @@ translators.set('wasm', async function(url) {
 const{ exports }=newWebAssembly.Instance(compiled,reflect.imports);
 for(constexptofObject.keys(exports))
 reflect.exports[expt].set(exports[expt]);
-});
+}).module;
 });