Uh oh!
There was an error while loading. Please reload this page.
v8 Synthetic Modules Implementation - #29846
Conversation
guybedford
commented
Oct 4, 2019
Relevant commit for review - cb2654c |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cb2654c to
fbb4715Comparenodejs-github-bot
commented
Oct 5, 2019
devsnek
commented
Oct 5, 2019
i'm pretty sure that REPLACEME is supposed to be a REPLACEME |
guybedford
commented
Oct 5, 2019
@devsnek you mean in that it's intended to be left in or replaced!? |
devsnek
commented
Oct 5, 2019
@guybedford you replaced an example showing how to add a new method to the docs. |
7d805f9 to
f5038a7Compareguybedford
commented
Oct 5, 2019
Ok I've rebased to the correct fix for the REPLACEME from #29737. |
f5038a7 to
2fed602Comparenodejs-github-bot
commented
Oct 6, 2019
devsnek
commented
Oct 6, 2019
@guybedford what's up with that |
guybedford
commented
Oct 6, 2019
@devsnek no Node master is fine actually. It was just a bug fix on this PR. |
devsnek
commented
Oct 6, 2019
@guybedford oh cool, just wanted to make sure it wasn't going in as a separate commit :) (for future reference, you can prefix commits with |
guybedford
commented
Oct 6, 2019
@Trott are we good to merge this later today? Or do we still do 72 hours for weekends? (I couldn't find reference to this in the collaborating guide anymore though) |
devsnek
commented
Oct 6, 2019
according to NCU this needs to wait one more hour |
PR-URL: #29846 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
guybedford
commented
Oct 6, 2019
Landed in ffd22e8. |
Trott
commented
Oct 8, 2019
@guybedford Yes, we got rid of the 72-hour rule. It's always 48 hours now. |
PR-URL: #29846 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
This updates uses of
createDynamicModuleto instead use a newModuleWrapsignature for creating v8 Synthetic Module Records instead.We still need to retain
createDynamicModulefor WASM due to imports and for the dynamic loader due to the exact behaviours, but these uses will likely be phased out over time anyway.This PR is based on top of #29737, so should merge after that. This is also prerequisite to the unflagging, as discussed in nodejs/modules#394.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes