Commit 9167ebd

Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd

2 files changed

Lines changed: 75 additions & 3 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
} elseif (value->IsString()) {
236236
Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
} elseif (value->IsArrayBufferView()) {
238+
} elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
value->IsSharedArrayBuffer()) {
239240
ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
} elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
!args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
Local<Object> obj = args[0].As<Object>();
26702672
Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
}
27922794
} elseif (value->IsNull()) {
27932795
r = sqlite3_bind_null(statement_, index);
2794-
} elseif (value->IsArrayBufferView()) {
2796+
} elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
value->IsSharedArrayBuffer()) {
27952798
ArrayBufferViewContents<uint8_t> buf(value);
27962799
r = sqlite3_bind_blob64(statement_,
27972800
index,

‎test/parallel/test-sqlite-typed-array-and-data-view.js‎

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit 9167ebd
Browse files
mike-git374aduh95
mike-git374
authored and
aduh95
committed
sqlite: bind ArrayBuffer
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
1 parent 0450ab6 commit 9167ebd
2 files changed
Lines changed: 75 additions & 3 deletions
File tree
‎src/node_sqlite.cc‎
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ void JSValueToSQLiteResult(Isolate* isolate,
235235
 } elseif (value->IsString()) {
236236
 Utf8Value val(isolate, value.As<String>());
237237
sqlite3_result_text(ctx, *val, val.length(), SQLITE_TRANSIENT);
238-
 } elseif (value->IsArrayBufferView()) {
238+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
239+
 value->IsSharedArrayBuffer()) {
239240
 ArrayBufferViewContents<uint8_t> buf(value);
240241
sqlite3_result_blob(ctx, buf.data(), buf.length(), SQLITE_TRANSIENT);
241242
 } elseif (value->IsBigInt()) {
@@ -2665,7 +2666,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
26652666
int anon_idx = 1;
26662667
int anon_start = 0;
26672668

2668-
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
2669+
if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
2670+
 !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
26692671
 Local<Object> obj = args[0].As<Object>();
26702672
 Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
26712673
 Local<Array> keys;
@@ -2791,7 +2793,8 @@ bool StatementSync::BindValue(const Local<Value>& value, const int index) {
27912793
 }
27922794
 } elseif (value->IsNull()) {
27932795
 r = sqlite3_bind_null(statement_, index);
2794-
 } elseif (value->IsArrayBufferView()) {
2796+
 } elseif (value->IsArrayBufferView() || value->IsArrayBuffer() ||
2797+
 value->IsSharedArrayBuffer()) {
27952798
 ArrayBufferViewContents<uint8_t> buf(value);
27962799
 r = sqlite3_bind_blob64(statement_,
27972800
 index,
‎test/parallel/test-sqlite-typed-array-and-data-view.js‎
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const { DatabaseSync } = require('node:sqlite');
55
const{ suite, test }=require('node:test');
66

77
constarrayBuffer=newUint8Array([1,2,3,4,5,6,7,8]).buffer;
8+
constsharedArrayBuffer=newSharedArrayBuffer(8);
9+
consttypedArrayOnSharedArrayBuffer=newUint8Array(sharedArrayBuffer);
10+
typedArrayOnSharedArrayBuffer.set([1,2,3,4,5,6,7,8]);
11+
812
constTypedArrays=[
913
['Int8Array',Int8Array],
1014
['Uint8Array',Uint8Array],
@@ -51,3 +55,68 @@ suite('StatementSync with TypedArray/DataView', () => {
5155
});
5256
}
5357
});
58+
59+
suite('StatementSync with ArrayBuffer and SharedArrayBuffer',()=>{
60+
constbuffers=[
61+
['ArrayBuffer',arrayBuffer],
62+
['SharedArrayBuffer',sharedArrayBuffer],
63+
];
64+
65+
for(const[displayName,buffer]ofbuffers){
66+
test(`${displayName} - anonymous binding`,(t)=>{
67+
constdb=newDatabaseSync(':memory:');
68+
t.after(()=>{db.close();});
69+
db.exec('CREATE TABLE test (data BLOB)');
70+
// insert
71+
{
72+
conststmt=db.prepare('INSERT INTO test VALUES (?)');
73+
stmt.run(buffer);
74+
}
75+
// select all
76+
{
77+
conststmt=db.prepare('SELECT * FROM test');
78+
constrow=stmt.get();
79+
t.assert.ok(row.datainstanceofUint8Array);
80+
t.assert.strictEqual(row.data.length,8);
81+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
82+
}
83+
// query
84+
{
85+
conststmt=db.prepare('SELECT * FROM test WHERE data = ?');
86+
constrows=stmt.all(buffer);
87+
t.assert.strictEqual(rows.length,1);
88+
t.assert.ok(rows[0].datainstanceofUint8Array);
89+
t.assert.strictEqual(rows[0].data.length,8);
90+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
91+
}
92+
});
93+
94+
test(`${displayName} - named binding (object)`,(t)=>{
95+
constdb=newDatabaseSync(':memory:');
96+
t.after(()=>{db.close();});
97+
db.exec('CREATE TABLE test (data BLOB)');
98+
// insert
99+
{
100+
conststmt=db.prepare('INSERT INTO test VALUES ($data)');
101+
stmt.run({'$data': buffer});
102+
}
103+
// select all
104+
{
105+
conststmt=db.prepare('SELECT * FROM test');
106+
constrow=stmt.get();
107+
t.assert.ok(row.datainstanceofUint8Array);
108+
t.assert.strictEqual(row.data.length,8);
109+
t.assert.deepStrictEqual(row.data,newUint8Array(arrayBuffer));
110+
}
111+
// query
112+
{
113+
conststmt=db.prepare('SELECT * FROM test WHERE data = $data');
114+
constrows=stmt.all({'$data': buffer});
115+
t.assert.strictEqual(rows.length,1);
116+
t.assert.ok(rows[0].datainstanceofUint8Array);
117+
t.assert.strictEqual(rows[0].data.length,8);
118+
t.assert.deepStrictEqual(rows[0].data,newUint8Array(arrayBuffer));
119+
}
120+
});
121+
}
122+
});
0 commit comments
Comments
 (0)