sqlite: bind ArrayBuffer - #62061

Merged
Renegade334 merged 2 commits into
nodejs:mainfrom
mike-git374:bind-array-buffer
Aug 5, 2026
Merged

sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom
mike-git374:bind-array-buffer

Conversation

@mike-git374

@mike-git374mike-git374 commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Fixes: #61396

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 1, 2026
Renegade334
Renegade334 reviewed Mar 1, 2026
View reviewed changes

@Renegade334Renegade334 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.

Comment threadsrc/node_sqlite.cc Outdated
Comment threadsrc/node_sqlite.cc Outdated
@codecov

codecovBot commented Mar 1, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.

Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️

... and 525 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334
Renegade334 reviewed Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions

github-actionsBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actionsgithub-actionsBot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@mike-git374

mike-git374 commented Aug 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Not stale, should be merged

@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334 self-assigned this Aug 4, 2026
@TrevorBurnhamTrevorBurnham mentioned this pull request Aug 4, 2026
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334

Renegade334 commented Aug 5, 2026

Copy link
Copy Markdown
Member

@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.

@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75494/

@github-actionsgithub-actionsBot removed the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Aug 5, 2026
@geeksilva97

geeksilva97 commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/75494/

yup, sounds good to me. first commit must be fixed though.

@Renegade334
Renegade334 merged commit 62acd48 into nodejs:mainAug 5, 2026
71 of 75 checks passed
@Renegade334

Renegade334 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Landed in 62acd48

@araujoguiaraujogui mentioned this pull request Aug 6, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit to photostructure/node-sqlite that referenced this pull request Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer

5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
sqlite: bind ArrayBuffer - #62061
Merged
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Aug 5, 2026
Merged
sqlite: bind ArrayBuffer#62061
Renegade334 merged 2 commits into
nodejs:mainfrom 
mike-git374:bind-array-buffer
Conversation
@mike-git374
@mike-git374mike-git374
commented
Mar 1, 2026

Copy link


Copy Markdown

Contributor
Fixes: #61396
@nodejs-github-bot
nodejs-github-bot
commented
Mar 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/sqlite
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
sqlite
Issues and PRs related to the SQLite subsystem.
labels
Mar 1, 2026
Renegade334
Renegade334
reviewed
Mar 1, 2026
View reviewed changes
@Renegade334Renegade334
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is probably reasonable, given that we already allow non-Uint8Array array buffer views. There are certain API surfaces that return raw ArrayBuffers (thinking webcrypto in particular), the required change is a one-liner, and there's already asymmetry in terms of the type conversion for BLOBs.
Comment threadsrc/node_sqlite.cc
Outdated

Comment threadsrc/node_sqlite.cc
Outdated

@codecov
codecovBot
commented
Mar 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (c9acf34) to head (553af2a).
⚠️ Report is 1594 commits behind head on main.
Files with missing linesPatch %Lines
src/node_sqlite.cc83.33%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62061 +/- ##
==========================================
+ Coverage 89.74% 90.28% +0.53% 
==========================================
Files 674 759 +85 Lines 204883 247637 +42754 Branches 39379 46677 +7298 ==========================================
+ Hits 183882 223583 +39701 - Misses 13279 15514 +2235 - Partials 7722 8540 +818 
Files with missing linesCoverage Δ
src/node_sqlite.cc80.51% <83.33%> (-0.39%)⬇️
... and 525 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Renegade334
Renegade334
reviewed
Mar 9, 2026
View reviewed changes
Comment threadsrc/node_sqlite.cc
Comment threadtest/parallel/test-sqlite-data-types.js
@github-actions
github-actionsBot
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
This pull request has been marked as stale due to 90 days of inactivity.

It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
@github-actionsgithub-actionsBot
added
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Jul 28, 2026
@mike-git374
mike-git374
commented
Aug 4, 2026

Copy link


Copy Markdown

ContributorAuthor
Not stale, should be merged
@trivikr

This comment was marked as resolved.

Sign in to view
@Renegade334Renegade334
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334
self-assigned this
Aug 4, 2026
@TrevorBurnhamTrevorBurnham
mentioned this pull request
Aug 4, 2026

Open

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@geeksilva97: if you're happy to ✅ the fixup commit, then I can land this manually once Jenkins is green.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
@github-actionsgithub-actionsBot
removed
the 
stale
Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
label
Aug 5, 2026
@geeksilva97
geeksilva97
commented
Aug 5, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
CI: https://ci.nodejs.org/job/node-test-pull-request/75494/
yup, sounds good to me. first commit must be fixed though.
@Renegade334
Renegade334
merged commit 62acd48
into
nodejs:mainAug 5, 2026

71 of 75 checks passed

@Renegade334
Renegade334
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
Landed in 62acd48
@araujoguiaraujogui
mentioned this pull request
Aug 6, 2026
 Merged

nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@araujogui
doc: document sqlite parameter binding
114e356
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mceachen added a commit
to photostructure/node-sqlite
that referenced
this pull request
Aug 9, 2026
@mceachen
fix(sqlite_impl): bind ArrayBuffer and SharedArrayBuffer as blobs
1e6ca73
Neither is an ArrayBufferView, so both fell through the named-parameter check
in BindParameters() and were read as a parameter object. That bound an empty
named-parameter set and left the real parameter unbound, so run(arrayBuffer)
silently stored SQL NULL instead of the blob.
Both now bind as BLOBs, matching nodejs/node#62061. SharedArrayBuffer cannot
be cast to Napi::ArrayBuffer and node-addon-api gates IsSharedArrayBuffer()
behind an experimental flag, so it is detected via Symbol.toStringTag --
realm-safe, unlike instanceof, which matters under Jest's per-file vm context
and in worker threads.
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
26e06da
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
67829bb
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
9167ebd
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
e52e573
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mike-git374@aduh95
sqlite: bind ArrayBuffer
fbe8861
PR-URL: #62061Fixes: #61396
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@araujogui@aduh95
doc: document sqlite parameter binding
b7932e6
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Renegade334Renegade334Renegade334 approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes

Assignees

@Renegade334Renegade334

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.sqliteIssues and PRs related to the SQLite subsystem.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

sqlite: bind ArrayBuffer


5 participants

@mike-git374@nodejs-github-bot@trivikr@Renegade334@geeksilva97