Skip to content

Commit 98963f2

Browse files
telenordtargos
authored andcommitted
http: revise _http_server.js
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: #30279 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 376ec01 commit 98963f2

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

‎lib/_http_server.js‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -253,13 +253,13 @@ function writeHead(statusCode, reason, obj) {
253253
}
254254
this.statusCode=statusCode;
255255

256-
varheaders;
256+
letheaders;
257257
if(this[kOutHeaders]){
258258
// Slow-case: when progressive API and header fields are passed.
259-
vark;
259+
letk;
260260
if(obj){
261-
varkeys=Object.keys(obj);
262-
for(vari=0;i<keys.length;i++){
261+
constkeys=Object.keys(obj);
262+
for(leti=0;i<keys.length;i++){
263263
k=keys[i];
264264
if(k)this.setHeader(k,obj[k]);
265265
}
@@ -487,7 +487,7 @@ function socketOnClose(socket, state) {
487487

488488
functionabortIncoming(incoming){
489489
while(incoming.length){
490-
varreq=incoming.shift();
490+
constreq=incoming.shift();
491491
req.aborted=true;
492492
req.emit('aborted');
493493
req.emit('close');
@@ -577,8 +577,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
577577
socketOnError.call(socket,ret);
578578
}elseif(parser.incoming&&parser.incoming.upgrade){
579579
// Upgrade or CONNECT
580-
varbytesParsed=ret;
581-
varreq=parser.incoming;
580+
constreq=parser.incoming;
582581
debug('SERVER upgrade or connect',req.method);
583582

584583
if(!d)
@@ -594,10 +593,10 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
594593
freeParser(parser,req,socket);
595594
parser=null;
596595

597-
vareventName=req.method==='CONNECT' ? 'connect' : 'upgrade';
596+
consteventName=req.method==='CONNECT' ? 'connect' : 'upgrade';
598597
if(eventName==='upgrade'||server.listenerCount(eventName)>0){
599598
debug('SERVER have listener for %s',eventName);
600-
varbodyHead=d.slice(bytesParsed,d.length);
599+
constbodyHead=d.slice(ret,d.length);
601600

602601
socket.readableFlowing=null;
603602
server.emit(eventName,req,socket,bodyHead);
@@ -659,7 +658,7 @@ function resOnFinish(req, res, socket, state, server) {
659658
}
660659
}else{
661660
// Start sending the next message
662-
varm=state.outgoing.shift();
661+
constm=state.outgoing.shift();
663662
if(m){
664663
m.assignSocket(socket);
665664
}
@@ -696,7 +695,7 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
696695
// so that we don't become overwhelmed by a flood of
697696
// pipelined requests that may never be resolved.
698697
if(!socket._paused){
699-
varws=socket._writableState;
698+
constws=socket._writableState;
700699
if(ws.needDrain||state.outgoingData>=socket.writableHighWaterMark){
701700
socket._paused=true;
702701
// We also need to pause the parser, but don't do that until after

0 commit comments

Comments
 (0)