Uh oh!
There was an error while loading. Please reload this page.
http: rename var to let and const - #30279
Closed
telenord wants to merge 3 commits into
Closed
Conversation
yorkie
reviewed
Nov 6, 2019
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR
approved these changes
Nov 6, 2019
trivikr
approved these changes
Nov 6, 2019
yorkie
approved these changes
Nov 7, 2019
gireeshpunathil
approved these changes
Nov 7, 2019
nodejs-github-bot
commented
Nov 7, 2019
Collaborator
jasnell
approved these changes
Nov 12, 2019
nodejs-github-bot
commented
Nov 12, 2019
Collaborator
nodejs-github-bot
commented
Nov 17, 2019
Collaborator
nodejs-github-bot
commented
Nov 18, 2019
Collaborator
Trott
commented
Nov 19, 2019
Member
@telenord Welcome and thanks for the pull request. If you want your GitHub account to linked as the author of these changes, please follow the instructions at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork. |
Trott
commented
Nov 19, 2019
Member
Landed in 422650a |
Trott
commented
Nov 19, 2019
Member
Thanks for the contribution! 🎉 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2019
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: nodejs#30279 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Nov 19, 2019
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: #30279 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: #30279 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
* replace var with const * eliminate unnecessary bytesParsed variable http: remove bytesParsed var PR-URL: #30279 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes