fs: lazy load createPromise/promiseResolve

jasnell · MylesBorins · commit 9b43af3703a1 · 2018-05-22T14:13:28.000-04:00
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/fs.js b/lib/fs.js
@@ -44,7 +44,6 @@ const {
 const util = require('util');
 const pathModule = require('path');
 const { isUint8Array } = require('internal/util/types');
-const { createPromise, promiseResolve } = process.binding('util');
 
 const binding = process.binding('fs');
 const fs = exports;
@@ -248,6 +247,7 @@ fs.exists = function(path, callback) {
 
 Object.defineProperty(fs.exists, internalUtil.promisify.custom, {
 value: (path) => {
+ const { createPromise, promiseResolve } = process.binding('util');
 const promise = createPromise();
 fs.exists(path, (exists) => promiseResolve(promise, exists));
 return promise;

-Original file line number
+Diff line change
 constutil=require('util');
 constpathModule=require('path');
 const{ isUint8Array }=require('internal/util/types');
 -const{ createPromise, promiseResolve }=process.binding('util');
 constbinding=process.binding('fs');
 constfs=exports;
 Object.defineProperty(fs.exists,internalUtil.promisify.custom,{
 value: (path)=>{
 +const{ createPromise, promiseResolve }=process.binding('util');
 constpromise=createPromise();
 fs.exists(path,(exists)=>promiseResolve(promise,exists));
 returnpromise;