Uh oh!
There was an error while loading. Please reload this page.
fs: lazy load promise related stuff - #20766
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
jasnell
commented
May 16, 2018
MemberAuthor
/cc @nodejs/fs |
jasnell
commented
May 16, 2018
MemberAuthor
joyeecheung
approved these changes
May 16, 2018
targos
approved these changes
May 16, 2018
JungMinu
approved these changes
May 16, 2018
TimothyGu
approved these changes
May 16, 2018
benjamingr
approved these changes
May 16, 2018
benjamingr
left a comment
Member
There was a problem hiding this comment.
The actual changes LGTM for cognitive overhead but I'd love to see a benchmark showing a measurable (even if small) impact.
I get why this would matter for require in userland but I'm not sure I understand why it would impact load times here.
lpinca
approved these changes
May 17, 2018
BridgeAR
approved these changes
May 18, 2018
BridgeAR
commented
May 18, 2018
Member
It is difficult to measure this with a small change like this alone. If you have a look at #20567 you can see that lazy loading does indeed significantly improve the performance. We still need snapshots but lazy loading is already a first good step and a good thing in general. |
jasnell added a commit
that referenced
this pull request
May 18, 2018
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell added a commit
that referenced
this pull request
May 18, 2018
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
commented
May 18, 2018
MemberAuthor
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20766 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are commits that were originally in #20734....
Lazy load the promises impl and promise utility bindings.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes