test: minor refactor in common/index.js

jasnell · targos · commit 9e1f7366db53 · 2018-09-20T07:41:15.000+02:00
PR-URL: #22738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com>
diff --git a/test/common/index.js b/test/common/index.js
@@ -143,16 +143,14 @@ const PIPE = (() => {
 return path.join(pipePrefix, pipeName);
 })();
 
-let hasIPv6;
-{
+const hasIPv6 = (() => {
 const iFaces = os.networkInterfaces();
 const re = isWindows ? /Loopback Pseudo-Interface/ : /lo/;
- hasIPv6 = Object.keys(iFaces).some(function(name) {
- return re.test(name) && iFaces[name].some(function(info) {
- return info.family === 'IPv6';
- });
+ return Object.keys(iFaces).some((name) => {
+ return re.test(name) &&
+ iFaces[name].some(({ family }) => family === 'IPv6');
 });
-}
+})();
 
 /*
 * Check that when running a test with

-Original file line number
+Diff line change
 returnpath.join(pipePrefix,pipeName);
 })();
 -lethasIPv6;
 -{
 +consthasIPv6=(()=>{
 constiFaces=os.networkInterfaces();
 constre=isWindows ? /LoopbackPseudo-Interface/ : /lo/;
 -hasIPv6=Object.keys(iFaces).some(function(name){
 -returnre.test(name)&&iFaces[name].some(function(info){
 -returninfo.family==='IPv6';
 -});
 +returnObject.keys(iFaces).some((name)=>{
 +returnre.test(name)&&
 +iFaces[name].some(({ family })=>family==='IPv6');
 });
 -}
 +})();
 /*
  * Check that when running a test with