Skip to content

test: minor refactor in common/index.js - #22738

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:test-common-minor-cleanup
Closed

test: minor refactor in common/index.js#22738
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:test-common-minor-cleanup

Conversation

@jasnell

@jasnelljasnell commented Sep 6, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/821/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 6, 2018
refack
refack reviewed Sep 6, 2018
View reviewed changes
Comment threadtest/common/index.js Outdated

@refackrefackSep 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need to be return

@jasnelljasnellSep 6, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, forgot to hit save lol

@jasnell
jasnellforce-pushed the test-common-minor-cleanup branch from b1924e5 to 2981827CompareSeptember 6, 2018 22:42
trivikr
trivikr reviewed Sep 7, 2018
View reviewed changes
Comment threadtest/common/index.js
@jasnell

jasnell commented Sep 12, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/17146/

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018
@gdams

gdams commented Sep 13, 2018

Copy link
Copy Markdown
Member

landed in: a93f035

@gdamsgdams closed this Sep 13, 2018
gdams pushed a commit that referenced this pull request Sep 13, 2018
@jasnellGeorge Adams
test: minor refactor in common/index.js
a93f035
PR-URL: #22738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 14, 2018
@jasnell@targos
test: minor refactor in common/index.js
01a5c7d
PR-URL: #22738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@targostargos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@jasnell@targos
test: minor refactor in common/index.js
00a8511
PR-URL: #22738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@jasnell@targos
test: minor refactor in common/index.js
9e1f736
PR-URL: #22738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@trivikrtrivikrtrivikr approved these changes
+2 more reviewers
@refackrefackrefack approved these changes
@gdamsgdamsgdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jasnell@nodejs-github-bot@gdams@refack@addaleax@lpinca@cjihrig@richardlau@trivikr