test: fix flaky test-child-process-fork-net

Trott · Myles Borins · commit a38b614ae952 · 2016-04-20T16:24:21.000-07:00
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: #5122 PR-URL: #6138 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/parallel/test-child-process-fork-net.js b/test/parallel/test-child-process-fork-net.js
@@ -1,8 +1,8 @@
 'use strict';
-var assert = require('assert');
-var common = require('../common');
-var fork = require('child_process').fork;
-var net = require('net');
+const assert = require('assert');
+const common = require('../common');
+const fork = require('child_process').fork;
+const net = require('net');
 
 // progress tracker
 function ProgressTracker(missing, callback) {
@@ -76,9 +76,9 @@ if (process.argv[2] === 'child') {
 server.close();
 });
 
- // we expect 10 connections and close events
- var connections = new ProgressTracker(10, progress.done.bind(progress));
- var closed = new ProgressTracker(10, progress.done.bind(progress));
+ // we expect 4 connections and close events
+ var connections = new ProgressTracker(4, progress.done.bind(progress));
+ var closed = new ProgressTracker(4, progress.done.bind(progress));
 
 // create server and send it to child
 var server = net.createServer();
@@ -99,7 +99,7 @@ if (process.argv[2] === 'child') {
 if (msg.what === 'listening') {
 // make connections
 var socket;
- for (var i = 0; i < 10; i++) {
+ for (var i = 0; i < 4; i++) {
 socket = net.connect(common.PORT, function() {
 console.log('CLIENT: connected');
 });

-Original file line number
+Diff line change
@@ @@ -1,8 +1,8 @@ @@
 'use strict';
 -varassert=require('assert');
 -varcommon=require('../common');
 -varfork=require('child_process').fork;
 -varnet=require('net');
 +constassert=require('assert');
 +constcommon=require('../common');
 +constfork=require('child_process').fork;
 +constnet=require('net');
 // progress tracker
 functionProgressTracker(missing,callback){
 server.close();
 });
 -// we expect 10 connections and close events
 -varconnections=newProgressTracker(10,progress.done.bind(progress));
 -varclosed=newProgressTracker(10,progress.done.bind(progress));
 +// we expect 4 connections and close events
 +varconnections=newProgressTracker(4,progress.done.bind(progress));
 +varclosed=newProgressTracker(4,progress.done.bind(progress));
 // create server and send it to child
 varserver=net.createServer();
 if(msg.what==='listening'){
 // make connections
 varsocket;
 -for(vari=0;i<10;i++){
 +for(vari=0;i<4;i++){
 socket=net.connect(common.PORT,function(){
 console.log('CLIENT: connected');
 });