Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-child-process-fork-net - #6138
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: nodejs#5122
Trott
commented
Apr 10, 2016
MemberAuthor
Stress test against current master to show failure: https://ci.nodejs.org/job/node-stress-single-test/588/nodes=pi2-raspbian-wheezy/console Stress test with this proposed change to show success: https://ci.nodejs.org/job/node-stress-single-test/590/nodes=pi2-raspbian-wheezy/console |
benjamingr
commented
Apr 10, 2016
Member
LGTM - why was it 10 to begin with? |
Trott
commented
Apr 10, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Apr 12, 2016
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: nodejs#5122 PR-URL: nodejs#6138 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott
commented
Apr 12, 2016
MemberAuthor
Landed in aba035f |
Closed
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins
commented
Apr 21, 2016
Contributor
@Trott lts? |
Trott
commented
Apr 21, 2016
MemberAuthor
@thealphanerd Yes, if it lands cleanly. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test, child_process, arm
Description of change
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.
Fixes: #5122