Commit acaf986

Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node can track the API after the implementation change lands in undici. Refs: nodejs/undici#5699 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #65365 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986

3 files changed

Lines changed: 346 additions & 0 deletions

File tree

β€Žbenchmark/fetch/headers.jsβ€Ž

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}

β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});

β€Žtest/parallel/test-whatwg-headers.jsβ€Ž

Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit acaf986
Browse files
anonrigaduh95
anonrig
authored and
aduh95
committed
test: add Headers coverage and benchmark
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 4a1c9a7 commit acaf986
3 files changed
Lines changed: 346 additions & 0 deletions
File tree
β€Žbenchmark/fetch/headers.jsβ€Ž
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
'use strict';
2+
constcommon=require('../common.js');
3+
4+
constbench=common.createBenchmark(main,{
5+
n: [1e5],
6+
method: [
7+
'construct-empty',
8+
'construct-object',
9+
'construct-headers',
10+
'get',
11+
'get-common',
12+
'set',
13+
'append',
14+
'has',
15+
'delete',
16+
'iterate',
17+
],
18+
});
19+
20+
constobjectInit={
21+
'Accept': 'application/json',
22+
'Content-Type': 'text/plain',
23+
'User-Agent': 'benchmark',
24+
'Authorization': 'Bearer token',
25+
'Cookie': 'a=1',
26+
'X-Request-Id': 'abc',
27+
'Cache-Control': 'no-cache',
28+
'Host': 'example.com',
29+
};
30+
31+
functionmain({ n, method }){
32+
constheaders=newHeaders(objectInit);
33+
constcopySource=newHeaders(objectInit);
34+
letresult;
35+
36+
bench.start();
37+
switch(method){
38+
case'construct-empty':
39+
for(leti=0;i<n;i++)
40+
newHeaders();
41+
break;
42+
case'construct-object':
43+
for(leti=0;i<n;i++)
44+
newHeaders(objectInit);
45+
break;
46+
case'construct-headers':
47+
for(leti=0;i<n;i++)
48+
newHeaders(copySource);
49+
break;
50+
case'get':
51+
for(leti=0;i<n;i++)
52+
result=headers.get('x-request-id');
53+
break;
54+
case'get-common':
55+
for(leti=0;i<n;i++)
56+
result=headers.get('content-type');
57+
break;
58+
case'set':
59+
for(leti=0;i<n;i++)
60+
headers.set('x-count',i);
61+
break;
62+
case'append':
63+
for(leti=0;i<n;i++){
64+
constcurrent=newHeaders();
65+
current.append('Accept','text/html');
66+
current.append('X-Custom',i);
67+
}
68+
break;
69+
case'has':
70+
for(leti=0;i<n;i++)
71+
result=headers.has('authorization');
72+
break;
73+
case'delete': {
74+
for(leti=0;i<n;i++){
75+
constcurrent=newHeaders(objectInit);
76+
current.delete('content-type');
77+
}
78+
break;
79+
}
80+
case'iterate':
81+
for(leti=0;i<n;i++){
82+
for(constentryofheaders)
83+
result=entry;
84+
}
85+
break;
86+
default:
87+
thrownewError(`Unexpected method "${method}"`);
88+
}
89+
bench.end(n);
90+
91+
// Keep a live use so V8 cannot DCE the loop.
92+
if(result===Symbol.for('benchmark-never'))
93+
thrownewError('unreachable');
94+
}
β€Žtest/benchmark/test-benchmark-fetch.jsβ€Ž
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
construnBenchmark=require('../common/benchmark');
6+
7+
runBenchmark('fetch',{NODEJS_BENCHMARK_ZERO_ALLOWED: 1});
β€Žtest/parallel/test-whatwg-headers.jsβ€Ž
Lines changed: 245 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,245 @@
1+
'use strict';
2+
3+
// Tests below are not from WPT.
4+
5+
require('../common');
6+
constassert=require('assert');
7+
constutil=require('util');
8+
9+
{
10+
constheaders=newHeaders();
11+
assert.strictEqual(headers.get('content-type'),null);
12+
assert.strictEqual(headers.has('content-type'),false);
13+
assert.deepStrictEqual([...headers],[]);
14+
assert.deepStrictEqual(headers.getSetCookie(),[]);
15+
}
16+
17+
{
18+
constheaders=newHeaders({
19+
'Content-Type': 'text/plain',
20+
'Accept': 'application/json',
21+
'X-Custom': '1',
22+
});
23+
assert.strictEqual(headers.get('content-type'),'text/plain');
24+
assert.strictEqual(headers.get('Content-Type'),'text/plain');
25+
assert.strictEqual(headers.get('ACCEPT'),'application/json');
26+
assert.ok(headers.has('accept'));
27+
assert.deepStrictEqual([...headers],[
28+
['accept','application/json'],
29+
['content-type','text/plain'],
30+
['x-custom','1'],
31+
]);
32+
}
33+
34+
{
35+
constheaders=newHeaders([
36+
['X-A','1'],
37+
['x-b','2'],
38+
['X-A','3'],
39+
]);
40+
assert.strictEqual(headers.get('x-a'),'1, 3');
41+
assert.deepStrictEqual([...headers],[
42+
['x-a','1, 3'],
43+
['x-b','2'],
44+
]);
45+
}
46+
47+
{
48+
constsource=newHeaders({'Content-Type': 'text/html'});
49+
source.append('Set-Cookie','a=b');
50+
source.append('Set-Cookie','c=d');
51+
constcopy=newHeaders(source);
52+
assert.strictEqual(copy.get('content-type'),'text/html');
53+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
54+
assert.deepStrictEqual([...copy],[...source]);
55+
copy.append('X-Copy','yes');
56+
assert.strictEqual(source.has('x-copy'),false);
57+
source.append('Set-Cookie','e=f');
58+
assert.deepStrictEqual(copy.getSetCookie(),['a=b','c=d']);
59+
}
60+
61+
{
62+
constheaders=newHeaders();
63+
headers.append('Accept','text/html');
64+
headers.append('accept','application/json');
65+
assert.strictEqual(headers.get('ACCEPT'),'text/html, application/json');
66+
headers.set('ACCEPT','image/png');
67+
assert.strictEqual(headers.get('accept'),'image/png');
68+
headers.delete('Accept');
69+
assert.strictEqual(headers.has('accept'),false);
70+
}
71+
72+
{
73+
constheaders=newHeaders();
74+
headers.append('Cookie','a=1');
75+
headers.append('cookie','b=2');
76+
assert.strictEqual(headers.get('cookie'),'a=1; b=2');
77+
}
78+
79+
{
80+
constheaders=newHeaders();
81+
headers.append('set-cookie','a=b');
82+
headers.append('Set-Cookie','c=d');
83+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
84+
constcloned=headers.getSetCookie();
85+
cloned.push('e=f');
86+
assert.deepStrictEqual(headers.getSetCookie(),['a=b','c=d']);
87+
headers.set('set-cookie','only=one');
88+
assert.deepStrictEqual(headers.getSetCookie(),['only=one']);
89+
headers.delete('SET-COOKIE');
90+
assert.deepStrictEqual(headers.getSetCookie(),[]);
91+
}
92+
93+
{
94+
constheaders=newHeaders();
95+
headers.set('a',' value ');
96+
assert.strictEqual(headers.get('a'),'value');
97+
headers.set('b','\r\n\t trimmed\t\n');
98+
assert.strictEqual(headers.get('b'),'trimmed');
99+
headers.set('c','\r');
100+
assert.strictEqual(headers.get('c'),'');
101+
headers.set('d','\n');
102+
assert.strictEqual(headers.get('d'),'');
103+
}
104+
105+
{
106+
constheaders=newHeaders();
107+
headers.set('a',['b','c']);
108+
assert.strictEqual(headers.get('a'),'b,c');
109+
headers.set('b',null);
110+
assert.strictEqual(headers.get('b'),'null');
111+
headers.set('c',1);
112+
assert.strictEqual(headers.get('c'),'1');
113+
}
114+
115+
{
116+
constheaders=newHeaders({
117+
c: '5',
118+
b: ['3','4'],
119+
a: ['1','2'],
120+
});
121+
assert.deepStrictEqual([...headers.entries()],[
122+
['a','1,2'],
123+
['b','3,4'],
124+
['c','5'],
125+
]);
126+
}
127+
128+
{
129+
constinit=[
130+
['foo','123'],
131+
['bar','456'],
132+
];
133+
constheaders=newHeaders(init);
134+
for(const[key,val]ofheaders){
135+
headers.delete(key);
136+
headers.set(`x-${key}`,val);
137+
}
138+
assert.deepStrictEqual([...headers],[
139+
['foo','123'],
140+
['x-x-bar','456'],
141+
]);
142+
}
143+
144+
{
145+
constheaders=newHeaders([
146+
['b','2'],
147+
['c','3'],
148+
['e','5'],
149+
]);
150+
headers.append('d','4');
151+
headers.append('a','1');
152+
headers.append('f','6');
153+
headers.append('c','7');
154+
headers.append('abc','8');
155+
assert.deepStrictEqual([...headers],[
156+
['a','1'],
157+
['abc','8'],
158+
['b','2'],
159+
['c','3, 7'],
160+
['d','4'],
161+
['e','5'],
162+
['f','6'],
163+
]);
164+
}
165+
166+
{
167+
constheaders=newHeaders({'Content-Type': 'application/json'});
168+
headers.set('Authorization','Bearer token');
169+
assert.strictEqual(
170+
util.inspect(headers,{depth: 1}),
171+
"Headers { 'Content-Type': 'application/json', Authorization: 'Bearer token' }",
172+
);
173+
}
174+
175+
{
176+
constheaders=newHeaders();
177+
assert.throws(()=>headers.get(),TypeError);
178+
assert.throws(()=>headers.has(),TypeError);
179+
assert.throws(()=>headers.delete(),TypeError);
180+
assert.throws(()=>headers.append('a'),TypeError);
181+
assert.throws(()=>headers.set('a'),TypeError);
182+
assert.throws(()=>headers.append('invalid @ name','x'),TypeError);
183+
assert.throws(()=>headers.set('a','a\nb'),TypeError);
184+
assert.throws(()=>headers.set('a','a\rb'),TypeError);
185+
assert.throws(()=>headers.set('a','a\0b'),TypeError);
186+
assert.throws(()=>headers.set(Symbol('x'),'y'),TypeError);
187+
assert.throws(()=>headers.set('a',Symbol('y')),TypeError);
188+
assert.throws(()=>headers.set('','x'),TypeError);
189+
assert.throws(()=>headers.set('a','hΓ©llo\u0100'),TypeError);
190+
assert.throws(()=>newHeaders(1),TypeError);
191+
assert.throws(()=>newHeaders('1'),TypeError);
192+
assert.throws(()=>newHeaders([['undici','fetch'],['fetch']]),TypeError);
193+
}
194+
195+
{
196+
assert.throws(()=>Headers.prototype.get.call(null,'a'),{
197+
name: 'TypeError',
198+
code: 'ERR_INVALID_THIS',
199+
});
200+
assert.throws(()=>Headers.prototype.append.call({},'a','b'),{
201+
name: 'TypeError',
202+
code: 'ERR_INVALID_THIS',
203+
});
204+
}
205+
206+
{
207+
assert.strictEqual(Headers.prototype.append.length,2);
208+
assert.strictEqual(Headers.prototype.constructor.length,0);
209+
assert.strictEqual(Headers.prototype.delete.length,1);
210+
assert.strictEqual(Headers.prototype.get.length,1);
211+
assert.strictEqual(Headers.prototype.has.length,1);
212+
assert.strictEqual(Headers.prototype.set.length,2);
213+
assert.strictEqual(Headers.prototype.entries,Headers.prototype[Symbol.iterator]);
214+
assert.strictEqual(Headers.prototype[Symbol.toStringTag],'Headers');
215+
assert.strictEqual(Object.prototype.toString.call(Headers.prototype),'[object Headers]');
216+
}
217+
218+
{
219+
constheaders=newHeaders();
220+
headers.set('content-type','text/plain');
221+
assert.strictEqual(headers.delete('content-type'),undefined);
222+
assert.strictEqual(headers.delete('missing'),undefined);
223+
assert.strictEqual(headers.set('a','b'),undefined);
224+
}
225+
226+
{
227+
constheaders=newHeaders();
228+
for(constnameof[
229+
'content-type',
230+
'accept',
231+
'user-agent',
232+
'cache-control',
233+
'set-cookie',
234+
]){
235+
headers.set(name,'value');
236+
assert.strictEqual(headers.get(name),'value');
237+
assert.ok(headers.has(name));
238+
}
239+
}
240+
241+
{
242+
constheaders=newHeaders();
243+
headers.append('fhqwhgads',`a${'\t'.repeat(1000)}a`);
244+
assert.strictEqual(headers.get('fhqwhgads'),`a${'\t'.repeat(1000)}a`);
245+
}
0 commit comments
Comments
Β (0)