test: add Headers coverage and benchmark - #65365

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged

test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a

Conversation

@anonrig

@anonriganonrig commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.

These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.

The implementation change lives in undici:

Refs: nodejs/undici#5699

@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/security-wg

@cursorcursorBot mentioned this pull request Aug 18, 2026
Draft
@nodejs-github-botnodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed the cursor/headers-class-performance-859a branch from 3ea8120 to eb22154CompareAugust 18, 2026 01:59
@anonriganonrig changed the title deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed the cursor/headers-class-performance-859a branch from eb22154 to 2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig marked this pull request as ready for review August 18, 2026 02:06
jasnell
jasnell previously requested changes Aug 18, 2026
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by

@codecov

codecovBot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84

see 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Aug 18, 2026
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.

@cursor
cursorBotforce-pushed the cursor/headers-class-performance-859a branch from 2edacb0 to 0225f7bCompareAugust 18, 2026 12:49
@anonrig

anonrig commented Aug 18, 2026

Copy link
Copy Markdown
MemberAuthor

Addressed the review feedback:

  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.

@anonriganonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 18, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75976/

@anonriganonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 19, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75994/

@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76132/

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76153/

@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76225/

@anonriganonrig added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit cc57cb7 into nodejs:mainAug 22, 2026
83 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in cc57cb7

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 22, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments
+1 more reviewer
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test: add Headers coverage and benchmark - #65365
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Aug 22, 2026
Merged
test: add Headers coverage and benchmark#65365
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
anonrig:cursor/headers-class-performance-859a
Conversation
@anonrig
@anonriganonrig
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.
These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.
The implementation change lives in undici:
Refs: nodejs/undici#5699
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/performance
  •  @nodejs/security-wg
@cursorcursorBot
mentioned this pull request
Aug 18, 2026
 Draft

@nodejs-github-botnodejs-github-bot
added

dependencies
PRs that add, update, or configure Node.js dependencies.
needs-ci
PRs that need a full CI run.
labels
Aug 18, 2026
@anonrig
test: add Headers coverage and benchmark
0225f7b
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
3ea8120 to
eb22154CompareAugust 18, 2026 01:59
@anonriganonrig
changed the title
deps: improve Headers class performancetest: add Headers coverage and benchmarkAug 18, 2026
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
eb22154 to
2edacb0CompareAugust 18, 2026 02:06
@anonrig
anonrig
marked this pull request as ready for review
August 18, 2026 02:06
jasnell
jasnell
previously requested changes
Aug 18, 2026
View reviewed changes
@jasnelljasnell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by
@codecov
codecovBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65365 +/- ##
==========================================
- Coverage 90.31% 90.14% -0.18% 
==========================================
Files 751 752 +1 Lines 249956 251884 +1928 Branches 47204 47379 +175 ==========================================
+ Hits 225745 227054 +1309 - Misses 15612 16147 +535 - Partials 8599 8683 +84 
see 98 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
mcollina
mcollina
approved these changes
Aug 18, 2026
View reviewed changes
@mcollinamcollina
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.
@cursor
cursorBotforce-pushed
the
cursor/headers-class-performance-859a
branch
from
2edacb0 to
0225f7bCompareAugust 18, 2026 12:49
@anonrig
anonrig
commented
Aug 18, 2026

Copy link


Copy Markdown

MemberAuthor
Addressed the review feedback:
  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.
@anonriganonrig
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75976/
@anonriganonrig
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75994/
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65365
✔ Done loading data for nodejs/node/pull/65365
----------------------------------- PR info ------------------------------------
Title test: add Headers coverage and benchmark (#65365)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:cursor/headers-class-performance-859a -> nodejs:main
Labels author ready, needs-ci, dependencies, commit-queue
Commits 1
- test: add Headers coverage and benchmark
Committers 1
- Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65365
Refs: https://github.com/nodejs/undici/pull/5699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 18 Aug 2026 01:56:23 GMT
✔ Approvals: 2
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65365#pullrequestreview-4957135129
✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65365#pullrequestreview-4964152707
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-19T14:17:00Z: https://ci.nodejs.org/job/node-test-pull-request/75994/
- Querying data for job/node-test-pull-request/75994/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90731/
✔ Data downloaded
✘ 3 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32324366349
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76132/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76153/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76225/
@anonriganonrig
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit cc57cb7
into
nodejs:mainAug 22, 2026

83 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
Landed in cc57cb7
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 22, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
8494625
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acaf986
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@anonrig@aduh95
test: add Headers coverage and benchmark
acc9716
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.
Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #65365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@gurgundaygurgundaygurgunday approved these changes
@jasnelljasnelljasnell left review comments

+1 more reviewer

@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.dependenciesPRs that add, update, or configure Node.js dependencies.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@mcollina@jasnell@mertcanaltin@gurgunday