repl: make console, module and require non-enumerable

This aligns these globals with the regular context.
PR-URL: #20717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Author: BridgeAR

lib/repl.js

@@ -793,7 +793,7 @@ REPLServer.prototype.createContext = function() {
 const_console=newConsole(this.outputStream);
 Object.defineProperty(context,'console',{
 configurable: true,
-enumerable: true,
+writable: true,
 value: _console
 });
 
@@ -813,9 +813,16 @@ REPLServer.prototype.createContext = function() {
 module.paths=
 CJSModule._resolveLookupPaths('<repl>',parentModule,true)||[];
 
-varrequire=makeRequireFunction(module);
-context.module=module;
-context.require=require;
+Object.defineProperty(context,'module',{
+configurable: true,
+writable: true,
+value: module
+});
+Object.defineProperty(context,'require',{
+configurable: true,
+writable: true,
+value: makeRequireFunction(module)
+});
 
 addBuiltinLibsToObject(context);
 

test/parallel/test-repl-console.js

@@ -4,32 +4,39 @@ const assert = require('assert');
 constrepl=require('repl');
 constvm=require('vm');
 
-// Create a dummy stream that does nothing
+// Create a dummy stream that does nothing.
 conststream=newcommon.ArrayStream();
 
-// Test when useGlobal is false
-testContext(repl.start({
-input: stream,
-output: stream,
-useGlobal: false
-}));
+// Test context when useGlobal is false.
+{
+constr=repl.start({
+input: stream,
+output: stream,
+useGlobal: false
+});
 
-functiontestContext(repl){
-constcontext=repl.createContext();
-// ensure that the repl context gets its own "console" instance
+// Ensure that the repl context gets its own "console" instance.
+assert(r.context.console);
+
+// Ensure that the repl console instance is not the global one.
+assert.notStrictEqual(r.context.console,console);
+
+constcontext=r.createContext();
+// Ensure that the repl context gets its own "console" instance.
 assert(context.consoleinstanceofrequire('console').Console);
 
-// ensure that the repl's global property is the context
+// Ensure that the repl's global property is the context.
 assert.strictEqual(context.global,context);
 
-// ensure that the repl console instance does not have a setter
-assert.throws(()=>context.console='foo',TypeError);
-repl.close();
+// Ensure that the repl console instance is writable.
+context.console='foo';
+r.close();
 }
 
-testContextSideEffects(repl.start({input: stream,output: stream}));
+// Test for context side effects.
+{
+constserver=repl.start({input: stream,output: stream});
 
-functiontestContextSideEffects(server){
 assert.ok(!server.underscoreAssigned);
 assert.strictEqual(server.lines.length,0);
 

test/parallel/test-repl-context.js

@@ -1,12 +1,10 @@
 // Reference: https://github.com/nodejs/node/pull/7624
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
 constrepl=require('repl');
 conststream=require('stream');
 
-common.globalCheck=false;
-
 constr=initRepl();
 
 r.input.emit('data','function a() { return 42; } (1)\n');

test/parallel/test-repl-function-definition-edge-case.js

@@ -2,8 +2,6 @@
 constcommon=require('../common');
 constrepl=require('repl');
 
-common.globalCheck=false;
-
 // Regression test for https://github.com/nodejs/node/issues/6802
 constinput=newcommon.ArrayStream();
 repl.start({ input,output: process.stdout,useGlobal: true});

test/parallel/test-repl-let-process.js

@@ -1,11 +1,9 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
 constStream=require('stream');
 constrepl=require('repl');
 
-common.globalCheck=false;
-
 consttests=[
 testSloppyMode,
 testStrictMode,

test/parallel/test-repl-mode.js

@@ -24,8 +24,6 @@ const common = require('../common');
 constassert=require('assert');
 constrepl=require('repl');
 
-common.globalCheck=false;
-
 // Create a dummy stream that does nothing
 conststream=newcommon.ArrayStream();
 

test/parallel/test-repl-options.js

@@ -21,7 +21,6 @@
 
 'use strict';
 constcommon=require('../common');
-common.globalCheck=false;
 
 constassert=require('assert');
 constrepl=require('repl');