Uh oh!
There was an error while loading. Please reload this page.
repl,test: fix global check - #20717
Closed
BridgeAR wants to merge 3 commits into
Closed
Conversation
These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed.
This aligns these globals with the regular context.
This flag is partially used in tests where it was not necessary and it is always possible to replace this flag with `common.allowGlobals`. This makes sure all globals are truly tested for.
Member
why is @nodejs/tsc tagged as an owner here=? |
BridgeAR
commented
May 14, 2018
MemberAuthor
This is done automatically. I think this is still somewhat WIP. |
richardlau
commented
May 14, 2018
Member
The change to Line 82 in 19374fd |
2 tasks
BridgeAR
commented
May 14, 2018
MemberAuthor
Trott
commented
May 14, 2018
Member
@nodejs/repl @nodejs/testing |
2 tasks
BridgeAR
commented
May 17, 2018
MemberAuthor
It would be nice if this could get some reviews :-) |
jasnell
approved these changes
May 17, 2018
4 tasks
BridgeAR
commented
May 18, 2018
MemberAuthor
It would be nice to get another LG before landing this. |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 19, 2018
These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed. PR-URL: nodejs#20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 19, 2018
This aligns these globals with the regular context. PR-URL: nodejs#20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 19, 2018
This flag is partially used in tests where it was not necessary and it is always possible to replace this flag with `common.allowGlobals`. This makes sure all globals are truly tested for. PR-URL: nodejs#20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BridgeAR
commented
May 19, 2018
MemberAuthor
Landed in 8254e38...becc3ec |
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
These values are all non-enumerable and will never be checked. By removing them, we make sure they will not become enumerable unnoticed. PR-URL: #20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
This aligns these globals with the regular context. PR-URL: #20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
This flag is partially used in tests where it was not necessary and it is always possible to replace this flag with `common.allowGlobals`. This makes sure all globals are truly tested for. PR-URL: #20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: remove untested knownGlobals:repl: make console, module and require non-enumerable:test: remove common.globalCheck:This fixes repl inconsistencies and removes code to actually make the globals check stricter.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes