Skip to content

Commit ae39039

Browse files
lpincatargos
authored andcommitted
stream: remove dead code
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent ecf6ae8 commit ae39039

1 file changed

Lines changed: 13 additions & 18 deletions

File tree

‎lib/stream.js‎

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,18 @@ Stream.Stream = Stream;
4343

4444
Stream._isUint8Array=require('internal/util/types').isUint8Array;
4545

46-
constversion=process.version.substr(1).split('.');
47-
if(version[0]===0&&version[1]<12){
48-
Stream._uint8ArrayToBuffer=Buffer;
49-
}else{
50-
try{
51-
constinternalBuffer=require('internal/buffer');
52-
Stream._uint8ArrayToBuffer=function_uint8ArrayToBuffer(chunk){
53-
returnnewinternalBuffer.FastBuffer(chunk.buffer,
54-
chunk.byteOffset,
55-
chunk.byteLength);
56-
};
57-
}catch(e){// eslint-disable-line no-unused-vars
58-
}
46+
try{
47+
constinternalBuffer=require('internal/buffer');
48+
Stream._uint8ArrayToBuffer=function_uint8ArrayToBuffer(chunk){
49+
returnnewinternalBuffer.FastBuffer(chunk.buffer,
50+
chunk.byteOffset,
51+
chunk.byteLength);
52+
};
53+
}catch(e){// eslint-disable-line no-unused-vars
54+
}
5955

60-
if(!Stream._uint8ArrayToBuffer){
61-
Stream._uint8ArrayToBuffer=function_uint8ArrayToBuffer(chunk){
62-
returnBuffer.prototype.slice.call(chunk);
63-
};
64-
}
56+
if(!Stream._uint8ArrayToBuffer){
57+
Stream._uint8ArrayToBuffer=function_uint8ArrayToBuffer(chunk){
58+
returnBuffer.prototype.slice.call(chunk);
59+
};
6560
}

0 commit comments

Comments
 (0)