Uh oh!
There was an error while loading. Please reload this page.
stream: remove dead code - #30041
Closed
lpinca wants to merge 2 commits into
Closed
Conversation
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: nodejs#30040
nodejs-github-bot
commented
Oct 20, 2019
Collaborator
ZYSzys
approved these changes
Oct 20, 2019
devnexen
approved these changes
Oct 20, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29514
MemberAuthor
@addaleax done, added as a separate commit here. I'll open a dedicated PR if needed/preferred. |
nodejs-github-bot
commented
Oct 20, 2019
Collaborator
richardlau
approved these changes
Oct 20, 2019
richardlau
left a comment
Member
There was a problem hiding this comment.
Would like some confirmation from @nodejs/streams that this doesn't affect readable-stream.
addaleax
commented
Oct 20, 2019
Member
cjihrig
approved these changes
Oct 20, 2019
gengjiawen
approved these changes
Oct 21, 2019
trivikr
approved these changes
Oct 21, 2019
SimonSchick
approved these changes
Oct 21, 2019
Trott pushed a commit
that referenced
this pull request
Oct 22, 2019
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Trott pushed a commit
that referenced
this pull request
Oct 22, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Trott
commented
Oct 22, 2019
Member
Landed in 4201cdd...1070153 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2019
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Nov 8, 2019
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 8, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 10, 2019
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 10, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 11, 2019
`String.prototype.split()` returns an array of strings so the branch is never taken. Fixes: #30040 PR-URL: #30041 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 11, 2019
The fallback code is no longer used when exporting to readable-stream. Refs: #29514 PR-URL: #30041Fixes: #30040 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.split()returns an array of strings so the branch isnever taken.
Fixes: #30040
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes