win: fix SIGQUIT on ClangCL

StefanStojanovic · RafaelGSS · commit b39fb9aa7f5f · 2025-05-02T17:05:52.000-03:00
PR-URL: #57659 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.h b/src/node.h
@@ -67,7 +67,8 @@
 #endif
 
 #ifdef _WIN32
-# define SIGKILL 9
+#define SIGQUIT 3
+#define SIGKILL 9
 #endif
 
 #include "v8.h" // NOLINT(build/include_order)
diff --git a/test/parallel/test-child-process-kill.js b/test/parallel/test-child-process-kill.js
@@ -42,9 +42,7 @@ assert.strictEqual(cat.killed, true);
 
 // Test different types of kill signals on Windows.
 if (common.isWindows) {
- // SIGQUIT is not supported on Windows 2022, Visual Studio 2022 ClangCL-produced node.exe.
- // TODO(StefanStojanovic): Investigate this and re-enable it when the issue is fixed.
- for (const sendSignal of ['SIGTERM', 'SIGKILL', /* 'SIGQUIT', */'SIGINT']) {
+ for (const sendSignal of ['SIGTERM', 'SIGKILL', 'SIGQUIT', 'SIGINT']) {
 const process = spawn('cmd');
 process.on('exit', (code, signal) => {
 assert.strictEqual(code, null);

-Original file line number
+Diff line change
 #endif
 #ifdef _WIN32
 -# defineSIGKILL9
 +#defineSIGQUIT3
 +#defineSIGKILL9
 #endif
 #include"v8.h"// NOLINT(build/include_order)
-Original file line number
+Diff line change
 // Test different types of kill signals on Windows.
 if(common.isWindows){
 -// SIGQUIT is not supported on Windows 2022, Visual Studio 2022 ClangCL-produced node.exe.
 -// TODO(StefanStojanovic): Investigate this and re-enable it when the issue is fixed.
 -for(constsendSignalof['SIGTERM','SIGKILL',/* 'SIGQUIT', */'SIGINT']){
 +for(constsendSignalof['SIGTERM','SIGKILL','SIGQUIT','SIGINT']){
 constprocess=spawn('cmd');
 process.on('exit',(code,signal)=>{
 assert.strictEqual(code,null);