Skip to content

win: fix SIGQUIT on ClangCL - #57659

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-sigquit-fix
Apr 3, 2025
Merged

win: fix SIGQUIT on ClangCL#57659
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-sigquit-fix

Conversation

@StefanStojanovic

@StefanStojanovicStefanStojanovic commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the cause of the failure when killing the process with SIGQUIT on Windows on a ClangCL-produced binary. Since it is fixed now, the test is reenabled.

@StefanStojanovicStefanStojanovic added the windows Issues and PRs related to the Windows platform. label Mar 28, 2025
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 28, 2025
@codecov

codecovBot commented Mar 28, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (1123585) to head (1b6a5c2).
Report is 50 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57659 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.01% 
==========================================
Files 630 630 Lines 185055 185055 Branches 36216 36220 +4 ==========================================
+ Hits 166975 166997 +22 + Misses 11042 11035 -7 + Partials 7038 7023 -15
Files with missing linesCoverage Δ
src/node.h92.15% <ø> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 approved these changes Mar 28, 2025
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is failing though

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65929/

@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65974/

@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65993/

@StefanStojanovicStefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 668a0b8 into nodejs:mainApr 3, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Landed in 668a0b8

@StefanStojanovicStefanStojanovic added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 4, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@StefanStojanovic@RafaelGSS
win: fix SIGQUIT on ClangCL
cddf7aa
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@StefanStojanovic@RafaelGSS
win: fix SIGQUIT on ClangCL
b39fb9a
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@StefanStojanovic@aduh95
win: fix SIGQUIT on ClangCL
53929f4
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@StefanStojanovic@RafaelGSS
win: fix SIGQUIT on ClangCL
7ebbebe
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@StefanStojanovic@aduh95
win: fix SIGQUIT on ClangCL
0e73617
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@StefanStojanovic@aduh95
win: fix SIGQUIT on ClangCL
1b5a7c6
PR-URL: #57659
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StefanStojanovic@nodejs-github-bot@jasnell@lpinca@aduh95