test: checks on napi factory wrap’s finalization

Fixes: #22396
PR-URL: #22612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

Author: legendecas

test/addons-napi/7_factory_wrap/binding.cc

@@ -15,9 +15,14 @@ napi_value CreateObject(napi_env env, napi_callback_info info) {
 napi_value Init(napi_env env, napi_value exports) {
 NAPI_CALL(env, MyObject::Init(env));
 
-NAPI_CALL(env,
-// NOLINTNEXTLINE (readability/null_usage)
-napi_create_function(env, "exports", -1, CreateObject, NULL, &exports));
+ napi_property_descriptor descriptors[] = {
+DECLARE_NAPI_GETTER("finalizeCount", MyObject::GetFinalizeCount),
+DECLARE_NAPI_PROPERTY("createObject", CreateObject),
+ };
+
+NAPI_CALL(env, napi_define_properties(
+ env, exports, sizeof(descriptors) / sizeof(*descriptors), descriptors));
+
 return exports;
 }
 

test/addons-napi/7_factory_wrap/myobject.cc

@@ -1,17 +1,26 @@
 #include"myobject.h"
 #include"../common.h"
 
+staticint finalize_count = 0;
+
 MyObject::MyObject() : env_(nullptr), wrapper_(nullptr) {}
 
 MyObject::~MyObject() { napi_delete_reference(env_, wrapper_); }
 
 voidMyObject::Destructor(napi_env env,
 void* nativeObject,
 void* /*finalize_hint*/) {
+ ++finalize_count;
  MyObject* obj = static_cast<MyObject*>(nativeObject);
 delete obj;
 }
 
+napi_value MyObject::GetFinalizeCount(napi_env env, napi_callback_info info) {
+ napi_value result;
+NAPI_CALL(env, napi_create_int32(env, finalize_count, &result));
+return result;
+}
+
 napi_ref MyObject::constructor;
 
 napi_status MyObject::Init(napi_env env) {

test/addons-napi/7_factory_wrap/myobject.h

@@ -7,6 +7,7 @@ class MyObject {
 public:
 static napi_status Init(napi_env env);
 staticvoidDestructor(napi_env env, void* nativeObject, void* finalize_hint);
+static napi_value GetFinalizeCount(napi_env env, napi_callback_info info);
 static napi_status NewInstance(napi_env env,
  napi_value arg,
  napi_value* instance);

test/addons-napi/7_factory_wrap/test.js

@@ -1,14 +1,25 @@
 'use strict';
+// Flags: --expose-gc
+
 constcommon=require('../../common');
 constassert=require('assert');
-constcreateObject=require(`./build/${common.buildType}/binding`);
+consttest=require(`./build/${common.buildType}/binding`);
 
-constobj=createObject(10);
-assert.strictEqual(obj.plusOne(),11);
-assert.strictEqual(obj.plusOne(),12);
-assert.strictEqual(obj.plusOne(),13);
+assert.strictEqual(test.finalizeCount,0);
+(()=>{
+constobj=test.createObject(10);
+assert.strictEqual(obj.plusOne(),11);
+assert.strictEqual(obj.plusOne(),12);
+assert.strictEqual(obj.plusOne(),13);
+})();
+global.gc();
+assert.strictEqual(test.finalizeCount,1);
 
-constobj2=createObject(20);
-assert.strictEqual(obj2.plusOne(),21);
-assert.strictEqual(obj2.plusOne(),22);
-assert.strictEqual(obj2.plusOne(),23);
+(()=>{
+constobj2=test.createObject(20);
+assert.strictEqual(obj2.plusOne(),21);
+assert.strictEqual(obj2.plusOne(),22);
+assert.strictEqual(obj2.plusOne(),23);
+})();
+global.gc();
+assert.strictEqual(test.finalizeCount,2);

test/addons-napi/8_passing_wrapped/test.js

@@ -6,11 +6,12 @@ const assert = require('assert');
 constaddon=require(`./build/${common.buildType}/binding`);
 
 letobj1=addon.createObject(10);
-constobj2=addon.createObject(20);
+letobj2=addon.createObject(20);
 constresult=addon.add(obj1,obj2);
 assert.strictEqual(result,30);
 
 // Make sure the native destructor gets called.
 obj1=null;
+obj2=null;
 global.gc();
-assert.strictEqual(addon.finalizeCount(),1);
+assert.strictEqual(addon.finalizeCount(),2);